Skip to content

Commit a0865ae

Browse files
committed
test: fix test failures due to behavior change and hardcoded project ID
1 parent 8298c1d commit a0865ae

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITOpenTelemetryTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,10 @@ public void testListDatasetsTraced() {
9999
assertEquals(200L, attrs.get(HttpTracingRequestInitializer.HTTP_RESPONSE_STATUS_CODE));
100100
assertEquals("bigquery.googleapis.com", attrs.get(BigQueryTelemetryTracer.URL_DOMAIN));
101101
assertEquals(
102-
"https://bigquery.googleapis.com/bigquery/v2/projects/gcloud-devel/datasets?prettyPrint=false",
102+
"https://bigquery.googleapis.com/bigquery/v2/projects/" + bigqueryHelper.getOptions().getProjectId() + "/datasets?prettyPrint=false",
103103
attrs.get(HttpTracingRequestInitializer.URL_FULL));
104104
assertEquals(
105-
"//bigquery.googleapis.com/projects/gcloud-devel/datasets",
105+
"//bigquery.googleapis.com/projects/" + bigqueryHelper.getOptions().getProjectId() + "/datasets",
106106
attrs.get(BigQueryTelemetryTracer.GCP_RESOURCE_DESTINATION_ID));
107107
assertEquals(
108108
"projects/{+projectId}/datasets", attrs.get(BigQueryTelemetryTracer.URL_TEMPLATE));
@@ -146,19 +146,19 @@ public void testGetDatasetNotFoundTraced() {
146146
"projects/{+projectId}/datasets/{+datasetId}",
147147
attrs.get(BigQueryTelemetryTracer.URL_TEMPLATE));
148148
assertEquals(
149-
"https://bigquery.googleapis.com/bigquery/v2/projects/gcloud-devel/datasets/non_existent_dataset?prettyPrint=false",
149+
"https://bigquery.googleapis.com/bigquery/v2/projects/" + bigqueryHelper.getOptions().getProjectId() + "/datasets/non_existent_dataset?prettyPrint=false",
150150
attrs.get(HttpTracingRequestInitializer.URL_FULL));
151151
assertEquals(
152152
"bigquery.googleapis.com", attrs.get(HttpTracingRequestInitializer.SERVER_ADDRESS));
153153
assertEquals("bigquery.googleapis.com", attrs.get(BigQueryTelemetryTracer.URL_DOMAIN));
154154
assertEquals(
155-
"//bigquery.googleapis.com/projects/gcloud-devel/datasets/non_existent_dataset",
155+
"//bigquery.googleapis.com/projects/" + bigqueryHelper.getOptions().getProjectId() + "/datasets/non_existent_dataset",
156156
attrs.get(BigQueryTelemetryTracer.GCP_RESOURCE_DESTINATION_ID));
157157

158158
// Error attributes
159159
assertEquals("notFound", attrs.get(BigQueryTelemetryTracer.ERROR_TYPE));
160160
assertEquals(
161-
"Not found: Dataset gcloud-devel:non_existent_dataset",
161+
"Not found: Dataset " + bigqueryHelper.getOptions().getProjectId() + ":non_existent_dataset",
162162
attrs.get(BigQueryTelemetryTracer.STATUS_MESSAGE));
163163
}
164164
}
@@ -197,7 +197,7 @@ public void testClientErrorAndRetriesTraced() {
197197
Map<AttributeKey<?>, Object> attrs = span.getAttributes().asMap();
198198
checkGeneralAttributes(attrs);
199199
assertEquals(
200-
"https://invalid-host-name-12345.com:8080/bigquery/v2/projects/gcloud-devel/datasets?prettyPrint=false",
200+
"https://invalid-host-name-12345.com:8080/bigquery/v2/projects/" + bigqueryHelper.getOptions().getProjectId() + "/datasets?prettyPrint=false",
201201
(String) attrs.get(HttpTracingRequestInitializer.URL_FULL));
202202
assertEquals(
203203
"invalid-host-name-12345.com", attrs.get(HttpTracingRequestInitializer.SERVER_ADDRESS));
@@ -206,7 +206,7 @@ public void testClientErrorAndRetriesTraced() {
206206
assertEquals(
207207
"projects/{+projectId}/datasets", attrs.get(BigQueryTelemetryTracer.URL_TEMPLATE));
208208
assertEquals(
209-
"//bigquery.googleapis.com/projects/gcloud-devel/datasets",
209+
"//bigquery.googleapis.com/projects/" + bigqueryHelper.getOptions().getProjectId() + "/datasets",
210210
attrs.get(BigQueryTelemetryTracer.GCP_RESOURCE_DESTINATION_ID));
211211
checkRetryAttribute(span, rpcSpanCount);
212212

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpcTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ public void testHttpTracingEnabled_GenericException_SetsAttributes() throws Exce
10801080
"java.io.IOException",
10811081
rpcSpan.getAttributes().get(BigQueryTelemetryTracer.EXCEPTION_TYPE));
10821082
assertEquals(
1083-
"CLIENT_UNKNOWN_ERROR", rpcSpan.getAttributes().get(BigQueryTelemetryTracer.ERROR_TYPE));
1083+
"IOException", rpcSpan.getAttributes().get(BigQueryTelemetryTracer.ERROR_TYPE));
10841084
}
10851085

10861086
@Test

0 commit comments

Comments
 (0)