Skip to content

Commit ac8cf3e

Browse files
committed
opt out StorageOptions and add unit tests
1 parent 7e04774 commit ac8cf3e

3 files changed

Lines changed: 19 additions & 1 deletion

File tree

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryOptionsTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,11 @@ void dataFormatOptionsSetterHasPrecedence() {
9292

9393
assertTrue(options.getDataFormatOptions().useInt64Timestamp());
9494
}
95+
96+
@Test
97+
void testUseJwtAccessWithScope_defaultsToFalse() {
98+
BigQueryOptions options = BigQueryOptions.newBuilder().setProjectId("project-id").build();
99+
100+
assertFalse(options.getUseJwtAccessWithScope());
101+
}
95102
}

java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageOptions.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,9 @@ public DefaultStorageRpcFactory() {
112112
public abstract static class Builder
113113
extends ServiceOptions.Builder<Storage, StorageOptions, Builder> {
114114

115-
Builder() {}
115+
Builder() {
116+
setUseJwtAccessWithScope(false);
117+
}
116118

117119
Builder(StorageOptions options) {
118120
super(options);

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/StorageOptionsBuilderTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,15 @@ public void grpc() throws Exception {
6969
() -> assertThat(rebuilt.hashCode()).isEqualTo(base.hashCode()));
7070
}
7171

72+
@Test
73+
public void useJwtAccessWithScope_defaultsToFalse() {
74+
HttpStorageOptions httpOptions = HttpStorageOptions.http().build();
75+
GrpcStorageOptions grpcOptions = GrpcStorageOptions.grpc().build();
76+
77+
assertThat(httpOptions.getUseJwtAccessWithScope()).isFalse();
78+
assertThat(grpcOptions.getUseJwtAccessWithScope()).isFalse();
79+
}
80+
7281
private static class MyStorageRetryStrategy implements StorageRetryStrategy {
7382

7483
@Override

0 commit comments

Comments
 (0)