Skip to content

Commit b020910

Browse files
committed
feat: Implement trace context extraction and injection interceptors
1 parent 378a3c1 commit b020910

File tree

6 files changed

+67
-6
lines changed

6 files changed

+67
-6
lines changed

sdk-platform-java/gax-java/gax-grpc/pom.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,16 @@
100100
</dependency>
101101

102102
<!-- test dependencies -->
103+
<dependency>
104+
<groupId>io.opentelemetry</groupId>
105+
<artifactId>opentelemetry-sdk</artifactId>
106+
<scope>test</scope>
107+
</dependency>
108+
<dependency>
109+
<groupId>io.opentelemetry</groupId>
110+
<artifactId>opentelemetry-sdk-testing</artifactId>
111+
<scope>test</scope>
112+
</dependency>
103113
<dependency>
104114
<groupId>io.grpc</groupId>
105115
<artifactId>grpc-s2a</artifactId>

sdk-platform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcClientCalls.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,16 @@ public static <RequestT, ResponseT> ClientCall<RequestT, ResponseT> newCall(
9090
channel = ((ChannelPool) channel).getChannel(grpcContext.getChannelAffinity());
9191
}
9292

93-
if (!grpcContext.getExtraHeaders().isEmpty()) {
94-
ClientInterceptor interceptor =
95-
MetadataUtils.newAttachHeadersInterceptor(grpcContext.getMetadata());
93+
java.util.Map<String, String> traceContext = new java.util.HashMap<>();
94+
grpcContext.getTracer().injectTraceContext(traceContext);
95+
96+
if (!grpcContext.getExtraHeaders().isEmpty() || !traceContext.isEmpty()) {
97+
Metadata metadata = grpcContext.getMetadata();
98+
for (java.util.Map.Entry<String, String> entry : traceContext.entrySet()) {
99+
metadata.put(
100+
Metadata.Key.of(entry.getKey(), Metadata.ASCII_STRING_MARSHALLER), entry.getValue());
101+
}
102+
ClientInterceptor interceptor = MetadataUtils.newAttachHeadersInterceptor(metadata);
96103
channel = ClientInterceptors.intercept(channel, interceptor);
97104
}
98105

sdk-platform-java/gax-java/gax-httpjson/pom.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,16 @@
8686
</dependency>
8787

8888
<!-- test dependencies -->
89+
<dependency>
90+
<groupId>io.opentelemetry</groupId>
91+
<artifactId>opentelemetry-sdk</artifactId>
92+
<scope>test</scope>
93+
</dependency>
94+
<dependency>
95+
<groupId>io.opentelemetry</groupId>
96+
<artifactId>opentelemetry-sdk-testing</artifactId>
97+
<scope>test</scope>
98+
</dependency>
8999
<dependency>
90100
<groupId>com.google.api</groupId>
91101
<artifactId>gax</artifactId>

sdk-platform-java/gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonClientCalls.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,25 @@ public static <RequestT, ResponseT> HttpJsonClientCall<RequestT, ResponseT> newC
8080
return httpJsonContext.getChannel().newCall(methodDescriptor, httpJsonContext.getCallOptions());
8181
}
8282

83+
static HttpJsonMetadata getMetadataWithTraceContext(HttpJsonCallContext context) {
84+
java.util.Map<String, String> traceHeaders = new java.util.HashMap<>();
85+
context.getTracer().injectTraceContext(traceHeaders);
86+
87+
java.util.Map<String, java.util.List<String>> finalHeaders =
88+
new java.util.HashMap<>(context.getExtraHeaders());
89+
for (java.util.Map.Entry<String, String> entry : traceHeaders.entrySet()) {
90+
finalHeaders.put(entry.getKey(), java.util.Collections.singletonList(entry.getValue()));
91+
}
92+
return HttpJsonMetadata.newBuilder().build().withHeaders(finalHeaders);
93+
}
94+
8395
static <RequestT, ResponseT> ApiFuture<ResponseT> futureUnaryCall(
8496
HttpJsonClientCall<RequestT, ResponseT> clientCall,
8597
RequestT request,
8698
HttpJsonCallContext context) {
8799
// Start the call
88100
HttpJsonFuture<ResponseT> future = new HttpJsonFuture<>(clientCall);
89-
clientCall.start(
90-
new FutureListener<>(future),
91-
HttpJsonMetadata.newBuilder().build().withHeaders(context.getExtraHeaders()));
101+
clientCall.start(new FutureListener<>(future), getMetadataWithTraceContext(context));
92102

93103
// Send the request
94104
try {

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/ApiTracer.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ default void requestSent() {}
196196
default void batchRequestSent(long elementCount, long requestSize) {}
197197
;
198198

199+
/** Extract the trace context from the tracer and add it to the given headers map. */
200+
default void injectTraceContext(java.util.Map<String, String> carrier) {}
201+
199202
/**
200203
* Annotates the attempt with the full resolved HTTP URL. Only relevant for HTTP transport.
201204
*

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracer.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,27 @@ public class SpanTracer implements ApiTracer {
5555
private final ApiTracerContext apiTracerContext;
5656
private Span attemptSpan;
5757

58+
@Override
59+
public void injectTraceContext(java.util.Map<String, String> carrier) {
60+
if (attemptSpan != null) {
61+
try {
62+
io.opentelemetry.context.Context context =
63+
io.opentelemetry.context.Context.current().with(attemptSpan);
64+
io.opentelemetry.api.trace.propagation.W3CTraceContextPropagator.getInstance()
65+
.inject(
66+
context,
67+
carrier,
68+
(c, k, v) -> {
69+
if (c != null) {
70+
c.put(k, v);
71+
}
72+
});
73+
} catch (NoSuchMethodError e) {
74+
// Silently ignore if incompatible OpenTelemetry version
75+
}
76+
}
77+
}
78+
5879
/**
5980
* Creates a new instance of {@code SpanTracer}.
6081
*

0 commit comments

Comments
 (0)