Skip to content

Commit b0689cf

Browse files
committed
chore(readme): address PR review feedback on client discovery and duplicate IAM naming
1 parent 5ce3a59 commit b0689cf

3 files changed

Lines changed: 8 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ Libraries are available on GitHub and Maven Central for developing Java applicat
7777
| [Functions](https://github.com/googleapis/google-cloud-java/tree/main/java-functions) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-functions.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-cloud-functions&core=gav) |
7878
| [GKE Hub API](https://github.com/googleapis/google-cloud-java/tree/main/java-gkehub) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-gkehub.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-cloud-gkehub&core=gav) |
7979
| [IAM](https://github.com/googleapis/google-cloud-java/tree/main/java-iam) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.api.grpc/proto-google-iam-v1.svg)](https://search.maven.org/search?q=g:com.google.api.grpc%20AND%20a:proto-google-iam-v1&core=gav) |
80-
| [IAM](https://github.com/googleapis/google-cloud-java/tree/main/java-iam-policy) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-iam-policy.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-iam-policy&core=gav) |
8180
| [IAM Admin API](https://github.com/googleapis/google-cloud-java/tree/main/java-iam-admin) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-iam-admin.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-iam-admin&core=gav) |
81+
| [IAM Policy](https://github.com/googleapis/google-cloud-java/tree/main/java-iam-policy) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-iam-policy.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-iam-policy&core=gav) |
8282
| [IAM Policy Troubleshooter API](https://github.com/googleapis/google-cloud-java/tree/main/java-policy-troubleshooter) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-policy-troubleshooter.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-cloud-policy-troubleshooter&core=gav) |
8383
| [IAM Service Account Credentials API](https://github.com/googleapis/google-cloud-java/tree/main/java-iamcredentials) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-iamcredentials.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-cloud-iamcredentials&core=gav) |
8484
| [Identity Access Context Manager](https://github.com/googleapis/google-cloud-java/tree/main/java-accesscontextmanager) | [![stable][stable-stability]][stable-description] | [![Maven](https://img.shields.io/maven-central/v/com.google.cloud/google-identity-accesscontextmanager.svg)](https://search.maven.org/search?q=g:com.google.cloud%20AND%20a:google-identity-accesscontextmanager&core=gav) |

generate-readme.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,13 @@ def all_clients() -> List[CloudClient]:
138138
client = client_for_repo(repo)
139139
if client:
140140
clients.append(client)
141-
clients.extend([client_for_module(module) for module in LIBRARIES_IN_MONOREPO if
142-
module not in REPO_EXCLUSION])
141+
for module in LIBRARIES_IN_MONOREPO:
142+
if module not in REPO_EXCLUSION:
143+
client = client_for_module(module)
144+
if client:
145+
clients.append(client)
143146

144-
return [client for client in clients if client]
147+
return clients
145148

146149

147150
clients = sorted(all_clients())

java-iam-policy/.repo-metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"api_shortname": "iam-policy",
3-
"name_pretty": "IAM",
3+
"name_pretty": "Google Cloud IAM Policy",
44
"product_documentation": "n/a",
55
"api_description": "n/a",
66
"client_documentation": "https://cloud.google.com/java/docs/reference/proto-google-iam-v1/latest/history",

0 commit comments

Comments
 (0)