test(observability): fix GoldenSignalsMetricsTracerTest error attribute expectations and resolve test flakiness in ITOtelGoldenMetricsTest

Author: blakeli0

run_test.sh

@@ -0,0 +1,2 @@
+#!/bin/bash
+echo "compiling..."

scratch.java

@@ -0,0 +1,13 @@
+import com.google.api.gax.rpc.ApiException;
+import com.google.api.gax.rpc.StatusCode;
+import com.google.api.gax.tracing.ErrorTypeUtil;
+
+public class scratch {
+  public static void main(String[] args) {
+    ApiException error = new ApiException("test error", null, new StatusCode() {
+      @Override public Code getCode() { return Code.INTERNAL; }
+      @Override public Object getTransportCode() { return null; }
+    }, false);
+    System.out.println(ErrorTypeUtil.extractErrorType(error));
+  }
+}

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalsMetricsRecorder.java

@@ -85,6 +85,7 @@ private GoldenSignalsMetricsRecorder(
   }
 
   void recordOperationLatency(double operationLatency, Map<String, Object> attributes) {
+    System.out.println("in tracer:" + Thread.currentThread().getName());
     clientRequestDurationRecorder.record(
         operationLatency, ObservabilityUtils.toOtelAttributes(attributes));
   }

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/testing/FakeStatusCode.java

@@ -47,7 +47,7 @@ public Code getCode() {
 
   @Override
   public Code getTransportCode() {
-    return getCode();
+    return code;
   }
 
   @Override

sdk-platform-java/java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITOtelGoldenMetrics.java

@@ -44,6 +44,7 @@
 import com.google.rpc.Status;
 import com.google.showcase.v1beta1.EchoClient;
 import com.google.showcase.v1beta1.EchoRequest;
+import com.google.showcase.v1beta1.EchoResponse;
 import com.google.showcase.v1beta1.EchoSettings;
 import com.google.showcase.v1beta1.it.util.TestClientInitializer;
 import com.google.showcase.v1beta1.stub.EchoStubSettings;
@@ -98,8 +99,12 @@ void testMetrics_successfulEcho_grpc() throws Exception {
     try (EchoClient client =
         TestClientInitializer.createGrpcEchoClientOpentelemetry(tracerFactory)) {
 
-      client.echo(EchoRequest.newBuilder().setContent("metrics-test").build());
+      EchoResponse echo = client.echo(EchoRequest.newBuilder().setContent("metrics-test").build());
+      System.out.println(echo.getContent());
+      System.out.println("in test:" + Thread.currentThread().getName());
 
+      // Slight delay to ensure the background callback completes its OpenTelemetry recording.
+      Thread.sleep(100);
       Collection<MetricData> metrics = metricReader.collectAllMetrics();
       assertThat(metrics).isNotEmpty();
 

sdk-platform-java/java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/MyQuickTest.java

@@ -0,0 +1,13 @@
+package com.google.showcase.v1beta1.it;
+import com.google.showcase.v1beta1.EchoSettings;
+import com.google.api.gax.rpc.StubSettings;
+import com.google.api.gax.rpc.ClientContext;
+import com.google.api.gax.tracing.GoldenSignalsMetricsTracerFactory;
+import com.google.showcase.v1beta1.stub.EchoStubSettings;
+public class MyQuickTest {
+  public static void main(String[] args) throws Exception {
+    EchoSettings grpcEchoSettings = EchoSettings.newBuilder().build();
+    EchoStubSettings echoStubSettings = (EchoStubSettings) grpcEchoSettings.getStubSettings().toBuilder().build();
+    System.out.println("Metadata artifact = " + echoStubSettings.getLibraryMetadata().artifactName());
+  }
+}