test(storage): support daemonized testbench container with keep-alive for concurrent forks

Author: Dhriti Chopra

java-storage/google-cloud-storage/pom.xml

@@ -460,6 +460,15 @@
           </dependency>
         </dependencies>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <configuration>
+          <systemPropertyVariables>
+            <testbench.keepAlive>true</testbench.keepAlive>
+          </systemPropertyVariables>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 

java-storage/google-cloud-storage/src/test/java/com/google/cloud/storage/it/runner/registry/TestBench.java

@@ -252,7 +252,7 @@ public void start() {
           ImmutableList.of(
               "docker",
               "run",
-              "-i",
+              "-d",
               "--rm",
               "--publish",
               port + ":9000",
@@ -318,14 +318,14 @@ public boolean shouldRetry(
 
   @Override
   public void stop() {
-    if (runningOutsideAlready) {
-      // if the server was running outside the tests already simply return
+    if (runningOutsideAlready || Boolean.getBoolean("testbench.keepAlive")) {
+      // if the server was running outside the tests already, or we want to keep it alive, simply return
       return;
     }
     try {
       process.destroy();
       process.waitFor(2, TimeUnit.SECONDS);
-      boolean attemptForceStopContainer = false;
+      boolean attemptForceStopContainer = true;
       try {
         int processExitValue = process.exitValue();
         if (processExitValue != 0) {