Skip to content

Commit c82e1d8

Browse files
committed
test: update DatastoreImplMetricsTest to expect singular GAX metric names
1 parent 5dc702f commit c82e1d8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

java-datastore/google-cloud-datastore/src/test/java/com/google/cloud/datastore/DatastoreImplMetricsTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ public void lookup_recordsOperationAndAttemptMetrics() {
516516

517517
// Verify operation latency
518518
Optional<MetricData> operationLatency =
519-
findMetric(metrics, TelemetryConstants.METRIC_NAME_OPERATION_LATENCY);
519+
findMetric(metrics, TelemetryConstants.METRIC_PREFIX + "/operation_latency");
520520
assertThat(operationLatency.isPresent()).isTrue();
521521
HistogramPointData opLatencyPoint =
522522
operationLatency.get().getHistogramData().getPoints().stream()
@@ -545,12 +545,12 @@ public void lookup_recordsOperationAndAttemptMetrics() {
545545

546546
// Verify operation count
547547
Optional<MetricData> operationCount =
548-
findMetric(metrics, TelemetryConstants.METRIC_NAME_OPERATION_COUNT);
548+
findMetric(metrics, TelemetryConstants.METRIC_PREFIX + "/operation_count");
549549
assertThat(operationCount.isPresent()).isTrue();
550550

551551
// Verify attempt latency
552552
Optional<MetricData> attemptLatency =
553-
findMetric(metrics, TelemetryConstants.METRIC_NAME_ATTEMPT_LATENCY);
553+
findMetric(metrics, TelemetryConstants.METRIC_PREFIX + "/attempt_latency");
554554
assertThat(attemptLatency.isPresent()).isTrue();
555555
HistogramPointData attLatencyPoint =
556556
attemptLatency.get().getHistogramData().getPoints().stream()
@@ -567,7 +567,7 @@ public void lookup_recordsOperationAndAttemptMetrics() {
567567

568568
// Verify attempt count
569569
Optional<MetricData> attemptCount =
570-
findMetric(metrics, TelemetryConstants.METRIC_NAME_ATTEMPT_COUNT);
570+
findMetric(metrics, TelemetryConstants.METRIC_PREFIX + "/attempt_count");
571571
assertThat(attemptCount.isPresent()).isTrue();
572572

573573
EasyMock.verify(rpcMock);
@@ -599,7 +599,7 @@ public void lookup_recordsFailureStatusOnError() {
599599

600600
// Verify operation latency with UNAVAILABLE status
601601
Optional<MetricData> operationLatency =
602-
findMetric(metrics, TelemetryConstants.METRIC_NAME_OPERATION_LATENCY);
602+
findMetric(metrics, TelemetryConstants.METRIC_PREFIX + "/operation_latency");
603603
assertThat(operationLatency.isPresent()).isTrue();
604604
HistogramPointData opLatencyPoint =
605605
operationLatency.get().getHistogramData().getPoints().stream()
@@ -621,7 +621,7 @@ public void lookup_recordsFailureStatusOnError() {
621621

622622
// Verify attempt metrics were also recorded with UNAVAILABLE
623623
Optional<MetricData> attemptCount =
624-
findMetric(metrics, TelemetryConstants.METRIC_NAME_ATTEMPT_COUNT);
624+
findMetric(metrics, TelemetryConstants.METRIC_PREFIX + "/attempt_count");
625625
assertThat(attemptCount.isPresent()).isTrue();
626626

627627
EasyMock.verify(rpcMock);

0 commit comments

Comments
 (0)