add test to confirm resend attribute does not get set on success flow

Author: ldetmer

java-bigquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpcTest.java

@@ -160,6 +160,9 @@ private void verifySpan(
     assertEquals(
         gcpResourceDestinationId,
         rpcSpan.getAttributes().get(BigQueryTelemetryTracer.GCP_RESOURCE_DESTINATION_ID));
+
+    // this attribute should never get set in a normal success flow
+    assertNull(rpcSpan.getAttributes().get(BigQueryTelemetryTracer.HTTP_REQUEST_RESEND_COUNT));
   }
 
   private void verifySpanProductionAttributes(
@@ -1168,12 +1171,7 @@ public void testResendCountOnRetry() throws Exception {
                 .orElse(null);
         assertNotNull(rpcSpan);
         assertEquals(
-            2L,
-            rpcSpan
-                .getAttributes()
-                .get(
-                    BigQueryTelemetryTracer
-                        .HTTP_REQUEST_RESEND_COUNT));
+            2L, rpcSpan.getAttributes().get(BigQueryTelemetryTracer.HTTP_REQUEST_RESEND_COUNT));
       } finally {
         com.google.cloud.bigquery.BigQueryRetryAlgorithm.setCurrentAttempt(0);
       }
@@ -1308,12 +1306,7 @@ public void testResendCountNotSetWhenDisabled() throws Exception {
                 .findFirst()
                 .orElse(null);
         assertNotNull(rpcSpan);
-        assertNull(
-            rpcSpan
-                .getAttributes()
-                .get(
-                        BigQueryTelemetryTracer
-                        .HTTP_REQUEST_RESEND_COUNT));
+        assertNull(rpcSpan.getAttributes().get(BigQueryTelemetryTracer.HTTP_REQUEST_RESEND_COUNT));
       } finally {
         com.google.cloud.bigquery.BigQueryRetryAlgorithm.setCurrentAttempt(0);
       }