Skip to content

Commit e6b0c09

Browse files
committed
chore: Address confusing code comment
1 parent 56dd1b2 commit e6b0c09

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,13 @@ public class DatastoreOptions extends ServiceOptions<Datastore, DatastoreOptions
5454
public static final String PROJECT_ID_ENV_VAR = "DATASTORE_PROJECT_ID";
5555
public static final String LOCAL_HOST_ENV_VAR = "DATASTORE_EMULATOR_HOST";
5656

57-
// Default to a slightly larger channel count to handle a larger initial QPS (up to ~500 QPS as
58-
// each channel can handle 100 max streams). This default remains a bit conservative and will
59-
// rely on the ChannelPool to resize according to the client's average load.
57+
// Default to a slightly larger channel count to handle a larger initial QPS. The initial
58+
// configuration
59+
// should be able to handle a max of ~500 QPS as each gRPC channel can handle 100 max streams
60+
// (limited
61+
// by Google Middleware). This default relies on the ChannelPool to resize according to the
62+
// client's
63+
// average load.
6064
public static final int INIT_CHANNEL_COUNT = 5;
6165
// Default to be larger than Gax's default (2) to better scale with spikes in requests
6266
static final int CHANNEL_POOL_DEFAULT_RESIZE_DELTA = 5;

0 commit comments

Comments
 (0)