Skip to content

Commit eac805d

Browse files
committed
fix(gapic-bom): remove handwritten storage boms
Remove `google-cloud-nio-bom` and `google-cloud-storage-bom` from `gapic-libraries-bom/pom.xml`. These are handwritten clients that should be added to `java-cloud-bom/google-cloud-bom/pom.xml` instead. Since `java-storage` and `java-storage-nio` are in the Kokoro `excluded_modules` list, their snapshot BOMs are not installed to the local `.m2` repository during CI installation steps. When `CreateBomCanaryProject` validates `gapic-libraries-bom/pom.xml`, the failure to resolve these imported snapshot BOMs caused Maven to report missing versions for their underlying jars. This reverts their accidental inclusion introduced in commits: - 1da80e6 (google-cloud-nio-bom) - 5a4afb5 (google-cloud-storage-bom)
1 parent c08d553 commit eac805d

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

gapic-libraries-bom/pom.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -957,13 +957,6 @@
957957
<type>pom</type>
958958
<scope>import</scope>
959959
</dependency>
960-
<dependency>
961-
<groupId>com.google.cloud</groupId>
962-
<artifactId>google-cloud-nio-bom</artifactId>
963-
<version>0.128.15-SNAPSHOT</version><!-- {x-version-update:google-cloud-nio:current} -->
964-
<type>pom</type>
965-
<scope>import</scope>
966-
</dependency>
967960
<dependency>
968961
<groupId>com.google.cloud</groupId>
969962
<artifactId>google-cloud-notebooks-bom</artifactId>
@@ -1270,13 +1263,6 @@
12701263
<type>pom</type>
12711264
<scope>import</scope>
12721265
</dependency>
1273-
<dependency>
1274-
<groupId>com.google.cloud</groupId>
1275-
<artifactId>google-cloud-storage-bom</artifactId>
1276-
<version>2.64.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-storage:current} -->
1277-
<type>pom</type>
1278-
<scope>import</scope>
1279-
</dependency>
12801266
<dependency>
12811267
<groupId>com.google.cloud</groupId>
12821268
<artifactId>google-cloud-storage-transfer-bom</artifactId>

0 commit comments

Comments
 (0)