Skip to content

Commit ef0946e

Browse files
committed
chore: address comments.
1 parent 323e4b7 commit ef0946e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/OpenTelemetryMetricsFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
@InternalApi
4343
public class OpenTelemetryMetricsFactory implements ApiTracerFactory {
4444

45-
private ApiTracerContext clientLevelTracerContext;
45+
private final ApiTracerContext clientLevelTracerContext;
4646
private final OpenTelemetry openTelemetry;
4747
private GoldenSignalsMetricsRecorder metricsRecorder;
4848

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/OpenTelemetryMetricsFactoryTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ void newTracerWithSpanName_shouldCreateTracer_ifMetricsRecorderIsNotNull() {
5656
factoryWithContext.newTracer(
5757
mock(ApiTracer.class), mock(SpanName.class), ApiTracerFactory.OperationType.Unary);
5858
assertThat(actual).isInstanceOf(OpenTelemetryMetricsTracer.class);
59+
assertThat(factoryWithContext).isNotEqualTo(tracerFactory);
5960
}
6061

6162
@Test

0 commit comments

Comments
 (0)