Skip to content

Commit f440367

Browse files
committed
chore: address pr feedback
1 parent 86d62b1 commit f440367

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryConnection.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ public class BigQueryConnection extends BigQueryNoOpsConnection {
8686
private static final String DEFAULT_JDBC_TOKEN_VALUE = "Google-BigQuery-JDBC-Driver";
8787
private static final String DEFAULT_VERSION = "0.0.0";
8888
private static final String BIGQUERY_SERVICE_NAME = "bigquery";
89-
private static final long MAX_PROJECTS_PER_PAGE = 10000L;
9089
private static final String PROJECT_LIST_FIELDS =
9190
"projects/projectReference/projectId,nextPageToken";
9291
private static final Set<String> SAFE_TO_LOG_PROPERTIES =
@@ -1254,7 +1253,10 @@ public synchronized List<String> getDiscoveredProjects() {
12541253
Bigquery lowLevelBq =
12551254
new Bigquery.Builder(transport, GsonFactory.getDefaultInstance(), initializer)
12561255
.setRootUrl(options.getResolvedApiaryHost(BIGQUERY_SERVICE_NAME))
1257-
.setApplicationName(DEFAULT_JDBC_TOKEN_VALUE)
1256+
.setApplicationName(
1257+
options.getApplicationName() != null
1258+
? options.getApplicationName()
1259+
: DEFAULT_JDBC_TOKEN_VALUE)
12581260
.build();
12591261

12601262
List<String> projects = new ArrayList<>();
@@ -1265,7 +1267,7 @@ public synchronized List<String> getDiscoveredProjects() {
12651267
.projects()
12661268
.list()
12671269
.setPageToken(pageToken)
1268-
.setMaxResults(MAX_PROJECTS_PER_PAGE)
1270+
.setMaxResults(getMaxResults())
12691271
.setFields(PROJECT_LIST_FIELDS)
12701272
.execute();
12711273
if (projectList.getProjects() != null) {

0 commit comments

Comments
 (0)