Skip to content

Commit fe86ba8

Browse files
committed
ci: hermetic build action version to use shared-dependencies verson
The hermetic build script relied on the sdk-platform-java release version to set the GitHub Action verison. Now it's in the monorepo and cannot rely on the version. Instead, let's use the shared dependencies BOM version in the Git tag.
1 parent 3a352fe commit fe86ba8

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.github/scripts/update_generation_config.sh

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,14 @@ function update_config() {
4848
}
4949

5050
# Update an action to a new version in GitHub action.
51+
# the second argument must have the git tag (including "v").
5152
function update_action() {
5253
local key_word=$1
5354
local new_value=$2
5455
local file=$3
5556
echo "Update ${key_word} to ${new_value} in ${file}"
5657
# use a different delimiter because the key_word contains "/".
57-
sed -i -e "s|${key_word}@v.*$|${key_word}@v${new_value}|" "${file}"
58+
sed -i -e "s|${key_word}@.*$|${key_word}@${new_value}|" "${file}"
5859
}
5960

6061
# The parameters of this script is:
@@ -143,12 +144,17 @@ rm -rf tmp-googleapis
143144
update_config "googleapis_commitish" "${latest_commit}" "${generation_config}"
144145

145146
# Update gapic-generator-java version to the latest
146-
latest_version=$(get_latest_released_version "com.google.api" "gapic-generator-java")
147-
update_config "gapic_generator_version" "${latest_version}" "${generation_config}"
148-
149-
# Update composite action version to latest gapic-generator-java version
147+
latest_gapic_generator_version=$(get_latest_released_version "com.google.api" "gapic-generator-java")
148+
update_config "gapic_generator_version" "${latest_gapic_generator_version}" "${generation_config}"
149+
150+
# Update the GitHub Actions reference to the latest.
151+
# After the google-cloud-java monorepo migration of sdk-platform-java,
152+
# we cannot rely on the gapic-generator-java version tag. Let's use
153+
# the shared dependencies BOM version
154+
latest_shared_dependencies_bom_version=$(get_latest_released_version "com.google.cloud" "google-cloud-shared-dependencies")
155+
# Update composite action version to latest gapic-libraries-bom version
150156
update_action "googleapis/google-cloud-java/sdk-platform-java/.github/scripts" \
151-
"${latest_version}" \
157+
"google-cloud-shared-dependencies/v${latest_shared_dependencies_bom_version}" \
152158
"${workflow}"
153159

154160
# Update libraries-bom version to the latest

0 commit comments

Comments
 (0)