Skip to content

test: Update KMS ITs to use GAPICs instead of gRPC stub#11781

Merged
lqiu96 merged 2 commits intomainfrom
update-kms-ITs
Oct 29, 2025
Merged

test: Update KMS ITs to use GAPICs instead of gRPC stub#11781
lqiu96 merged 2 commits intomainfrom
update-kms-ITs

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented Oct 28, 2025

Discovered in googleapis/sdk-platform-java#3942, it looks like KMS ITs are using gRPC generated stubs instead of the GAPIC stubs.

While this IT may not actually have that much use to simply test the GET/ CREATE/ LIST functionality of a service, we do use KMS in sdk-platform-java as a downstream test case.

@lqiu96 lqiu96 requested review from blakeli0 and mpeddada1 October 28, 2025 23:51
@lqiu96 lqiu96 marked this pull request as ready for review October 29, 2025 15:16
@lqiu96 lqiu96 requested a review from a team October 29, 2025 15:16
@blakeli0
Copy link
Copy Markdown
Contributor

Can we use test: instead of chore:?

@lqiu96 lqiu96 changed the title chore: Update KMS ITs to use GAPICs instead of gRPC stub test: Update KMS ITs to use GAPICs instead of gRPC stub Oct 29, 2025
@lqiu96
Copy link
Copy Markdown
Member Author

lqiu96 commented Oct 29, 2025

Can we use test: instead of chore:?

done

@lqiu96 lqiu96 merged commit 12b09f6 into main Oct 29, 2025
34 checks passed
@lqiu96 lqiu96 deleted the update-kms-ITs branch October 29, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants