chore: refactor all opentelemetry span logic for RPC calls into generic executeWithSpan function#12077
Merged
chore: refactor all opentelemetry span logic for RPC calls into generic executeWithSpan function#12077
Conversation
…ic executeWithSpan function
lqiu96
reviewed
Mar 16, 2026
Comment on lines
+211
to
+213
| "DatasetService", | ||
| "ListDatasets", | ||
| options, |
Member
There was a problem hiding this comment.
nit: Perhaps we can have a helper method to build the common attributes and pass the built Attributes to executeWithSpan. There's a lot of params passed to executeWithSpan
Contributor
Author
There was a problem hiding this comment.
this makes sense, I implemented a separate method to create the span, however I left the invocation inline to the call to executeWithSpan. If you think this is a readability issue let me know and I can make it is only call.
lqiu96
approved these changes
Mar 16, 2026
jinseopkim0
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to setup the ability to add new attributes to existing tracing span for the observability project. This is no-op functional change for the current code, but achieves the following:
Moves all tracing logic (creation, attribute setting, closing) into new executeWithSpan generic function. Is useful for potential future changes.
Adds the functionality to make each client span the current span. This does not have any affect on the traces themselves (see comparison below), but it does allow for us to retrieve this span in an HTTP interceptor and append additional attributes. See design: go/sdk:java-bigquery-observability. Without this change the current span returned is the parent span.
Example trace before change
Example trace after change