chore(bigquery): add Version.java update to release please for telemetry tracking#12314
chore(bigquery): add Version.java update to release please for telemetry tracking#12314
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a BigQuery telemetry version file to the release-please configuration. The reviewer identified that the file path was incorrectly added to the root package configuration instead of the specific java-bigquery section, which is necessary for correct artifact versioning.
| "sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg", | ||
| "java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/Version.java" |
There was a problem hiding this comment.
This file path appears to be added to the wrong section in release-please-config.json. It is currently under the root (.) package configuration, along with general sdk-platform-java files. Since this is a BigQuery-specific file, it should be added to the extra-files list within the java-bigquery package configuration block to ensure it is versioned correctly with other BigQuery artifacts. Please remove it from this section and add it to the java-bigquery section.
"sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg"There was a problem hiding this comment.
I don't think release-please looks in sub modules for configuration, so I believe this is the correct place to make this change
blakeli0
left a comment
blakeli0
left a comment
There was a problem hiding this comment.
Can we run release-please locally to make sure it works?
done, it Versions.java is updated correctly here |
3 participants
Add the Version.java used by bigquery telemetry to list of files release-please updates the version for. This is used to track the SDK version in span tracing.