Skip to content

chore(bigquery): add Version.java update to release please for telemetry tracking #12314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldetmer merged 1 commit into from
Mar 31, 2026
Merged

chore(bigquery): add Version.java update to release please for telemetry tracking #12314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"sdk-platform-java/.cloudbuild/library_generation/library_generation_airlock.Dockerfile",
"sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-a.cfg",
"sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-b.cfg",
"sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg"
"sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg",
"java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/Version.java"
Comment on lines +23 to +24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This file path appears to be added to the wrong section in release-please-config.json. It is currently under the root (.) package configuration, along with general sdk-platform-java files. Since this is a BigQuery-specific file, it should be added to the extra-files list within the java-bigquery package configuration block to ensure it is versioned correctly with other BigQuery artifacts. Please remove it from this section and add it to the java-bigquery section.

        "sdk-platform-java/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/presubmit/graalvm-native-c.cfg"

Copy link
Copy Markdown
Contributor Author

@ldetmer ldetmer Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think release-please looks in sub modules for configuration, so I believe this is the correct place to make this change

]
}
}
Expand Down
Loading