feat: [geocode] new module for geocode#12340
Conversation
cloud-java-bot
added
the
owlbot:run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reformats documentation URLs and API descriptions in generation_config.yaml for better consistency and adds a new geocode library entry. The review feedback suggests moving the geocode entry to its correct alphabetical position, formatting its documentation URLs to match the rest of the file, and renaming the library to maintain a consistent naming convention for Maps APIs.
| issue_tracker: https://issuetracker.google.com/issues?q=status:open%20componentid:310170 | ||
| GAPICs: | ||
| - proto_path: google/cloud/iot/v1 | ||
| - api_shortname: geocode |
There was a problem hiding this comment.
The new geocode entry is not in alphabetical order. It is currently placed after iot, but it should be located earlier in the file (e.g., between geminidataanalytics and gkerecommender) to maintain the alphabetical sorting of the libraries list.
| - proto_path: google/cloud/iot/v1 | ||
| - api_shortname: geocode | ||
| name_pretty: Geocoding API | ||
| product_documentation: https://developers.google.com/maps/documentation/geocoding/overview |
There was a problem hiding this comment.
For consistency with the other entries in this file and the reformatting applied throughout this pull request, the product_documentation URL should be moved to a new line.
product_documentation:
https://developers.google.com/maps/documentation/geocoding/overview| product_documentation: https://developers.google.com/maps/documentation/geocoding/overview | ||
| api_description: The Geocoding API is a service that accepts a place as an address, | ||
| latitude and longitude coordinates, or Place ID. | ||
| client_documentation: https://cloud.google.com/java/docs/reference/google-maps-geocode/latest/overview |
There was a problem hiding this comment.
For consistency with the other entries in this file and the reformatting applied throughout this pull request, the client_documentation URL should be moved to a new line.
client_documentation:
https://cloud.google.com/java/docs/reference/google-maps-geocode/latest/overview| cloud_api: false | ||
| GAPICs: | ||
| - proto_path: google/maps/geocode/v4 | ||
| library_name: java-maps-geocode |
There was a problem hiding this comment.
The library_name java-maps-geocode is inconsistent with other Maps libraries in this file, such as maps-routeoptimization (line 1676). Consider using maps-geocode to maintain a consistent naming convention across the repository.
library_name: maps-geocode
2 participants
Generated by @diegomarquezp via generate_new_client_hermetic_build.yaml
Command used: