feat: [datalineage] new module for datalineage#12341
feat: [datalineage] new module for datalineage#12341cloud-java-bot wants to merge 1 commit intomainfrom
Conversation
cloud-java-bot
added
the
owlbot:run
cloud-java-bot
added
the
owlbot:run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily reformats generation_config.yaml by moving documentation URLs to new lines and updating several api_description fields to use multi-line strings. It also introduces a new datalineage library entry. The review feedback identifies an incorrect documentation link for the BigQuery Connection API and suggests merging the new datalineage entry into the existing lineage service to maintain a more cohesive client library.
| release_level: stable | ||
| client_documentation: https://cloud.google.com/bigquery/docs/reference/reservations/rpc/google.cloud.bigquery.reservation.v1beta1 | ||
| client_documentation: | ||
| https://cloud.google.com/bigquery/docs/reference/reservations/rpc/google.cloud.bigquery.reservation.v1beta1 |
There was a problem hiding this comment.
The client_documentation link for the BigQuery Connection API appears to be incorrect, as it currently points to the BigQuery Reservation RPC reference. It should point to the Java client library reference for BigQuery Connection.
https://cloud.google.com/java/docs/reference/google-cloud-bigqueryconnection/latest/overview| - api_shortname: datalineage | ||
| name_pretty: Data Lineage API | ||
| product_documentation: https://cloud.google.com/dataplex/docs/about-data-lineage | ||
| api_description: Data lineage is a visual map that tracks the entire lifecycle of | ||
| your data. It shows you where your data comes from (the origin), where it travels | ||
| (the destinations), and all the changes or transformations that happen along the | ||
| way. | ||
| client_documentation: | ||
| https://cloud.google.com/java/docs/reference/google-cloud-datalineage/latest/overview | ||
| release_level: preview | ||
| distribution_name: com.google.cloud:google-cloud-datalineage | ||
| api_id: datalineage.googleapis.com | ||
| library_type: GAPIC_AUTO | ||
| group_id: com.google.cloud | ||
| cloud_api: true | ||
| GAPICs: | ||
| - proto_path: google/cloud/datacatalog/lineage/configmanagement/v1 | ||
| requires_billing: true |
There was a problem hiding this comment.
This new datalineage entry appears to be a duplicate or a sub-component of the existing lineage service (see lines 814-816 which point to google/cloud/datacatalog/lineage/v1). Instead of creating a separate library google-cloud-datalineage for the configmanagement sub-package, consider merging this into the existing lineage library by adding the new proto_path to its GAPICs list. This maintains a more cohesive client library for the Data Lineage service.
2 participants
Generated by @diegomarquezp via generate_new_client_hermetic_build.yaml
Command used: