diff --git a/sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py b/sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py index 9ee7514a4dec..f3e1882c6521 100644 --- a/sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py +++ b/sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py @@ -273,7 +273,8 @@ def update_parent_pom(filename: str, modules: List[module.Module]): new_dependency.append(new_group) new_dependency.append(new_artifact) new_dependency.append(new_version) - new_dependency.append(comment) + if "vertexai" not in m.artifact_id: + new_dependency.append(comment) new_dependency.tail = "\n " dependencies.insert(1, new_dependency) @@ -310,7 +311,8 @@ def update_bom_pom(filename: str, modules: List[module.Module]): new_dependency.append(new_group) new_dependency.append(new_artifact) new_dependency.append(new_version) - new_dependency.append(comment) + if "vertexai" not in m.artifact_id: + new_dependency.append(comment) if index == num_modules - 1: new_dependency.tail = "\n " diff --git a/sdk-platform-java/hermetic_build/library_generation/tests/owlbot/fix_poms_unit_tests.py b/sdk-platform-java/hermetic_build/library_generation/tests/owlbot/fix_poms_unit_tests.py index 2e6645482725..a284d837ec4b 100644 --- a/sdk-platform-java/hermetic_build/library_generation/tests/owlbot/fix_poms_unit_tests.py +++ b/sdk-platform-java/hermetic_build/library_generation/tests/owlbot/fix_poms_unit_tests.py @@ -35,6 +35,53 @@ def test_update_poms_group_id_does_not_start_with_google_correctly(self): for sub_dir in sub_dirs: self.__remove_file_in_subdir(ad_manager_resource, sub_dir) + def test_update_bom_pom_excludes_vertexai_comment(self): + import tempfile + from library_generation.owlbot.src.poms.module import Module + from library_generation.owlbot.src.fix_poms import update_bom_pom + + # Minimal XML structure + initial_xml = """ + + + + + +""" + + with tempfile.NamedTemporaryFile(mode="w+", delete=False) as tmp: + tmp.write(initial_xml) + tmp_path = tmp.name + + try: + modules = [ + Module( + group_id="com.google.cloud", + artifact_id="google-cloud-vertexai", + version="1.0.0", + release_version="1.0.0", + ), + Module( + group_id="com.google.cloud", + artifact_id="google-cloud-datastore", + version="1.0.0", + release_version="1.0.0", + ), + ] + + update_bom_pom(tmp_path, modules) + + with open(tmp_path, "r") as f: + content = f.read() + + self.assertNotIn("x-version-update:google-cloud-vertexai:current", content) + self.assertIn("x-version-update:google-cloud-datastore:current", content) + + finally: + import os + + os.unlink(tmp_path) + @classmethod def __copy__golden(cls, base_dir: str, subdir: str): golden = os.path.join(base_dir, subdir, "pom-golden.xml")