Skip to content

chore: Add upper bounds dependencies file to renovate config #12562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 3 commits into from
Apr 2, 2026
+26 −4
Merged

chore: Add upper bounds dependencies file to renovate config #12562

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
627fb9f
chore: Add upper bounds dependencies file to renovate config
lqiu96 Apr 1, 2026
2c8cb4c
chore: Update to the package rules section
lqiu96 Apr 1, 2026
7cb255d
chore: fix renovate config managerFilePatterns
lqiu96 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@
"/^com.google.cloud:google-cloud-storage/",
"/^com.google.apis:google-api-services-storage/"
]
},
{
"matchManagers": [
"custom.regex"
],
"semanticCommitType": "chore",
"matchFileNames": [
"sdk-platform-java/dependencies.txt"
],
"matchDatasources": [
"maven"
],
"groupName": "Upper Bound Dependencies File",
"description": "Group all dependencies from the Upper Bound Dependencies File",
"enabled": true
}
],
"includePaths": [
Expand All @@ -35,6 +50,7 @@
"java-samples/native-image-sample/pom.xml",
"java-shared-dependencies/first-party-dependencies/pom.xml",
"java-shared-dependencies/third-party-dependencies/pom.xml",
"sdk-platform-java/dependencies.txt",
".kokoro/nightly/graalvm-native*.cfg",
".kokoro/nightly/graalvm-sub-jobs/native*/common.cfg",
".kokoro/presubmit/graalvm-native*.cfg",
Expand All @@ -47,7 +63,7 @@
"customManagers": [
{
"customType": "regex",
"managerFilePatterns": [
"fileMatch": [
"/^.kokoro/nightly/graalvm-native.*.cfg$/",
"/^.kokoro/presubmit/graalvm-native.*.cfg$/",
"/^.kokoro/presubmit/*-graalvm-native-presubmit.cfg$/",
Expand All @@ -62,7 +78,7 @@
},
{
"customType": "regex",
"managerFilePatterns": [
"fileMatch": [
"/java-dns/README.md/",
"/java-notification/README.md/",
"/java-samples/native-image-sample/pom.xml/",
Expand All @@ -76,7 +92,7 @@
},
{
"customType": "regex",
"managerFilePatterns": [
"fileMatch": [
"/.github/workflows/ci.yaml/",
"/.github/workflows/generated_files_sync.yaml/"
],
Expand All @@ -88,14 +104,20 @@
},
{
"customType": "regex",
"managerFilePatterns": [
"fileMatch": [
"/^.github/workflows/unmanaged_dependency_check.yaml$/"
],
"matchStrings": [
"uses: googleapis/sdk-platform-java/java-shared-dependencies/unmanaged-dependency-check@google-cloud-shared-dependencies/v(?<currentValue>.+?)\\n"
],
"depNameTemplate": "com.google.cloud:sdk-platform-java-config",
"datasourceTemplate": "maven"
},
{
"customType": "regex",
"fileMatch": ["sdk-platform-java/dependencies.txt"],
"matchStrings": ["(?<depName>.*),(.*)=(?<currentValue>.*)"],
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regular expression (?<depName>.*),(.*)=(?<currentValue>.*) is overly broad and potentially fragile. Because .* is greedy and matches almost any character, it could capture leading/trailing whitespace or match unintended lines (such as comments containing a comma and an equals sign). Using more restrictive character classes like [^,\s]+ ensures that Renovate captures only valid package names and versions, preventing lookup failures.

      "matchStrings": ["(?<depName>[^,\s]+),[^=\s]+=(?<currentValue>[^\s]+)"],

"datasourceTemplate": "maven"
}
]
}
Loading