chore: minor fixes/additions to big query telemetry IT tests#12622
chore: minor fixes/additions to big query telemetry IT tests#12622
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the telemetry configuration by moving the SERVER_ADDRESS and SERVER_PORT attribute keys from BigQueryTelemetryTracer to HttpTracingRequestInitializer and updating the BQ_GCP_CLIENT_REPO constant. Additionally, it enhances the ITOpenTelemetryTest suite by adding assertions for span kind and status, verifying null attributes, and introducing a test case for disabled tracing. I have no feedback to provide.
| AttributeKey.longKey("http.request.body.size"); | ||
| public static final AttributeKey<Long> HTTP_RESPONSE_BODY_SIZE = | ||
| AttributeKey.longKey("http.response.body.size"); | ||
| public static final AttributeKey<String> SERVER_ADDRESS = |
There was a problem hiding this comment.
Appropriate file
Why do we need these two attributes to be moved here?
There was a problem hiding this comment.
This is where I'm setting them. I have attributes broken up by HTTP interceptors attributes set in this class and client side attributes set in HttpBigQueryRpc class. I think it makes it easier to distinguish between the 2.
Some minor clean up for bigquery integration testing for telemetry based on test plan.
This PR includes: