Skip to content

chore: minor fixes/additions to big query telemetry IT tests#12622

Merged
ldetmer merged 1 commit intomainfrom
bg-it-telemetry
Apr 2, 2026
Merged

chore: minor fixes/additions to big query telemetry IT tests#12622
ldetmer merged 1 commit intomainfrom
bg-it-telemetry

Conversation

@ldetmer
Copy link
Copy Markdown
Contributor

@ldetmer ldetmer commented Apr 2, 2026

Some minor clean up for bigquery integration testing for telemetry based on test plan.

This PR includes:

  1. renaming repo to mono repo
  2. migrating attribute keys to appropriate file
  3. adding check for client kind and span status, as well as validating attributes that should not be set are null
  4. added missing test for telemetry disabled if flag is not set

@ldetmer ldetmer requested review from a team as code owners April 2, 2026 14:16
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the telemetry configuration by moving the SERVER_ADDRESS and SERVER_PORT attribute keys from BigQueryTelemetryTracer to HttpTracingRequestInitializer and updating the BQ_GCP_CLIENT_REPO constant. Additionally, it enhances the ITOpenTelemetryTest suite by adding assertions for span kind and status, verifying null attributes, and introducing a test case for disabled tracing. I have no feedback to provide.

AttributeKey.longKey("http.request.body.size");
public static final AttributeKey<Long> HTTP_RESPONSE_BODY_SIZE =
AttributeKey.longKey("http.response.body.size");
public static final AttributeKey<String> SERVER_ADDRESS =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate file

Why do we need these two attributes to be moved here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where I'm setting them. I have attributes broken up by HTTP interceptors attributes set in this class and client side attributes set in HttpBigQueryRpc class. I think it makes it easier to distinguish between the 2.

@ldetmer ldetmer enabled auto-merge (squash) April 2, 2026 14:36
@ldetmer ldetmer merged commit 9276fbf into main Apr 2, 2026
111 of 112 checks passed
@ldetmer ldetmer deleted the bg-it-telemetry branch April 2, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants