Skip to content

chore: remove language from bigquery telemetry tracing #12623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldetmer merged 1 commit into from
Apr 2, 2026
+0 −13
Merged

chore: remove language from bigquery telemetry tracing #12623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...d-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ private BigQueryTelemetryTracer() {}
public static final String BQ_GCP_CLIENT_SERVICE = "bigquery";
public static final String BQ_GCP_CLIENT_REPO = "googleapis/google-cloud-java";
public static final String BQ_GCP_CLIENT_ARTIFACT = "google-cloud-bigquery";
public static final String BQ_GCP_CLIENT_LANGUAGE = "java";

// TODO: migrate to use gax attributes keys
// https://github.com/googleapis/google-cloud-java/issues/12099
Expand All @@ -47,8 +46,6 @@ private BigQueryTelemetryTracer() {}
AttributeKey.stringKey("gcp.client.repo");
public static final AttributeKey<String> GCP_CLIENT_ARTIFACT =
AttributeKey.stringKey("gcp.client.artifact");
public static final AttributeKey<String> GCP_CLIENT_LANGUAGE =
AttributeKey.stringKey("gcp.client.language");
public static final AttributeKey<String> GCP_RESOURCE_DESTINATION_ID =
AttributeKey.stringKey("gcp.resource.destination.id");
public static final AttributeKey<String> RPC_SYSTEM_NAME =
Expand All @@ -68,7 +65,6 @@ public static void addCommonAttributeToSpan(Span span) {
span.setAttribute(GCP_CLIENT_SERVICE, BQ_GCP_CLIENT_SERVICE)
.setAttribute(GCP_CLIENT_REPO, BQ_GCP_CLIENT_REPO)
.setAttribute(GCP_CLIENT_ARTIFACT, BQ_GCP_CLIENT_ARTIFACT)
.setAttribute(GCP_CLIENT_LANGUAGE, BQ_GCP_CLIENT_LANGUAGE)
.setAttribute(GCP_CLIENT_VERSION, Version.VERSION);
}

Expand Down
3 changes: 0 additions & 3 deletions ...google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITOpenTelemetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,6 @@ private void checkGeneralAttributes(Map<AttributeKey<?>, Object> attrs) {
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_REPO,
attrs.get(BigQueryTelemetryTracer.GCP_CLIENT_REPO));
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_LANGUAGE,
attrs.get(BigQueryTelemetryTracer.GCP_CLIENT_LANGUAGE));
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_ARTIFACT,
attrs.get(BigQueryTelemetryTracer.GCP_CLIENT_ARTIFACT));
Expand Down
3 changes: 0 additions & 3 deletions ...gquery/src/test/java/com/google/cloud/bigquery/telemetry/BigQueryTelemetryTracerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,6 @@ public void testAddCommonAttributeToSpan() {
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_ARTIFACT,
spanData.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_ARTIFACT));
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_LANGUAGE,
spanData.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_LANGUAGE));
assertEquals(
Version.VERSION, spanData.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_VERSION));
}
Expand Down
3 changes: 0 additions & 3 deletions .../src/test/java/com/google/cloud/bigquery/telemetry/HttpTracingRequestInitializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,6 @@ private void closeAndVerifySpanData(
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_ARTIFACT,
span.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_ARTIFACT));
assertEquals(
BigQueryTelemetryTracer.BQ_GCP_CLIENT_LANGUAGE,
span.getAttributes().get(BigQueryTelemetryTracer.GCP_CLIENT_LANGUAGE));
assertEquals(
HttpTracingRequestInitializer.HTTP_RPC_SYSTEM_NAME,
span.getAttributes().get(BigQueryTelemetryTracer.RPC_SYSTEM_NAME));
Expand Down
Loading