Skip to content

test(o11y): expand coverage and cleanup of ITOtelTracing#12658

Merged
diegomarquezp merged 4 commits intomainfrom
observability/tracing/attribute-coverage
Apr 2, 2026
Merged

test(o11y): expand coverage and cleanup of ITOtelTracing#12658
diegomarquezp merged 4 commits intomainfrom
observability/tracing/attribute-coverage

Conversation

@diegomarquezp
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances OpenTelemetry tracing integration tests in the Java showcase. Key changes include adding assertions for RPC system names and response statuses in successful echo tests, introducing new tests for the Identity service's GetUser method to verify destination resource attributes, and refactoring error tracing tests to validate a broader range of error attributes such as exception types and status messages. I have no feedback to provide.

@diegomarquezp diegomarquezp marked this pull request as ready for review April 2, 2026 19:54
@diegomarquezp diegomarquezp requested a review from a team as a code owner April 2, 2026 19:54
@diegomarquezp diegomarquezp enabled auto-merge (squash) April 2, 2026 20:16
@diegomarquezp diegomarquezp merged commit c08d553 into main Apr 2, 2026
126 of 127 checks passed
@diegomarquezp diegomarquezp deleted the observability/tracing/attribute-coverage branch April 2, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants