test(o11y): expand coverage and cleanup of ITOtelTracing#12658
Merged
diegomarquezp merged 4 commits intomainfrom Apr 2, 2026
Merged
test(o11y): expand coverage and cleanup of ITOtelTracing#12658diegomarquezp merged 4 commits intomainfrom
diegomarquezp merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances OpenTelemetry tracing integration tests in the Java showcase. Key changes include adding assertions for RPC system names and response statuses in successful echo tests, introducing new tests for the Identity service's GetUser method to verify destination resource attributes, and refactoring error tracing tests to validate a broader range of error attributes such as exception types and status messages. I have no feedback to provide.
blakeli0
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.