Skip to content

test(o11y): expand coverage and cleanup of ITOtelTracing #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 4 commits into from
Apr 2, 2026
+158 −79
Merged

test(o11y): expand coverage and cleanup of ITOtelTracing #12658

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
897b99e
test(o11y): expand coverage and cleanup of ITOtelTracing
diegomarquezp Apr 2, 2026
cd93bbc
test: cleanup of ITOtelTracing
diegomarquezp Apr 2, 2026
720fa1e
Merge remote-tracking branch 'origin/main' into observability/tracing…
diegomarquezp Apr 2, 2026
5d5fcc5
fix: use proper function name
diegomarquezp Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 159 additions & 48 deletions ...a-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITOtelTracing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
import com.google.showcase.v1beta1.EchoRequest;
import com.google.showcase.v1beta1.EchoResponse;
import com.google.showcase.v1beta1.EchoSettings;
import com.google.showcase.v1beta1.GetUserRequest;
import com.google.showcase.v1beta1.IdentityClient;
import com.google.showcase.v1beta1.it.util.TestClientInitializer;
import com.google.showcase.v1beta1.stub.EchoStub;
import com.google.showcase.v1beta1.stub.EchoStubSettings;
Expand Down Expand Up @@ -152,6 +154,16 @@ void testTracing_successfulEcho_grpc() throws Exception {
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.RPC_SYSTEM_NAME_ATTRIBUTE)))
.isEqualTo("grpc");
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE)))
.isEqualTo("OK");
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.REPO_ATTRIBUTE)))
.isEqualTo(SHOWCASE_REPO);
assertThat(
Expand Down Expand Up @@ -223,6 +235,16 @@ void testTracing_successfulEcho_httpjson() throws Exception {
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.RPC_SYSTEM_NAME_ATTRIBUTE)))
.isEqualTo("http");
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.longKey(ObservabilityAttributes.HTTP_RESPONSE_STATUS_ATTRIBUTE)))
.isEqualTo(200L);
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.REPO_ATTRIBUTE)))
.isEqualTo(SHOWCASE_REPO);
assertThat(
Expand Down Expand Up @@ -274,6 +296,66 @@ private long computeExpectedHttpJsonResponseSize(Message message)
return jsonPayload.getBytes(StandardCharsets.UTF_8).length;
}

@Test
void testTracing_successfulIdentityGetUser_grpc() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);

try (IdentityClient client = TestClientInitializer.createGrpcIdentityClientOpentelemetry(tracingFactory)) {

try {
client.getUser(GetUserRequest.newBuilder().setName("users/test-user").build());
} catch (Exception e) {
// Ignored, the showcase server may not have this user, but trace is still
// generated.
}

List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertThat(spans).isNotEmpty();

SpanData attemptSpan = spans.stream()
.filter(span -> span.getName().equals("google.showcase.v1beta1.Identity/GetUser"))
.findFirst()
.orElseThrow(() -> new AssertionError("Incorrect span name"));
assertThat(
attemptSpan
.getAttributes()
.get(
AttributeKey.stringKey(
ObservabilityAttributes.DESTINATION_RESOURCE_ID_ATTRIBUTE)))
.isEqualTo("users/test-user");
}
}

@Test
void testTracing_successfulIdentityGetUser_httpjson() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);

try (IdentityClient client = TestClientInitializer.createHttpJsonIdentityClientOpentelemetry(tracingFactory)) {

try {
client.getUser(GetUserRequest.newBuilder().setName("users/test-user").build());
} catch (Exception e) {
// Ignored, the showcase server may not have this user, but trace is still
// generated.
}

List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertThat(spans).isNotEmpty();

SpanData attemptSpan = spans.stream()
.filter(span -> span.getName().equals("GET v1beta1/{name=users/*}"))
.findFirst()
.orElseThrow(() -> new AssertionError("Incorrect span name"));
assertThat(
attemptSpan
.getAttributes()
.get(
AttributeKey.stringKey(
ObservabilityAttributes.DESTINATION_RESOURCE_ID_ATTRIBUTE)))
.isEqualTo("users/test-user");
}
}

@Test
void testTracing_retry_grpc() throws Exception {
final int attempts = 5;
Expand Down Expand Up @@ -424,7 +506,7 @@ void testTracing_retry_httpjson() throws Exception {
assertThat(resendCounts).containsExactlyElementsIn(expectedCounts).inOrder();
}

private void verifyErrorTypeAttribute(String expectedErrorType) {
private SpanData getErrorAttribute() {
List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertThat(spans).isNotEmpty();

Expand All @@ -439,16 +521,11 @@ private void verifyErrorTypeAttribute(String expectedErrorType) {
!= null)
.findFirst()
.orElseThrow(() -> new AssertionError("Span with error.type not found"));

assertThat(
errorSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.ERROR_TYPE_ATTRIBUTE)))
.isEqualTo(expectedErrorType);
return errorSpan;
}

@Test
void testTracing_failedEcho_grpc_recordsErrorType() throws Exception {
void testTracing_failedEcho_grpc_recordsErrorAttributes() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);

ClientInterceptor interceptor =
Expand Down Expand Up @@ -490,52 +567,28 @@ public void sendMessage(ReqT message) {}
EchoRequest echoRequest = EchoRequest.newBuilder().build();

assertThrows(UnavailableException.class, () -> client.echo(echoRequest));
verifyErrorTypeAttribute("UNAVAILABLE");
}
}
@Test
void testTracing_statusCodes_grpc() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);
EchoRequest errorRequest =
EchoRequest.newBuilder()
.setError(
Status.newBuilder().setCode(StatusCode.Code.INVALID_ARGUMENT.ordinal()).build())
.build();
EchoRequest successRequest = EchoRequest.newBuilder().setContent("tracing-test").build();

try (EchoClient grpcClient =
TestClientInitializer.createGrpcEchoClientOpentelemetry(tracingFactory)) {

grpcClient.echo(successRequest);
assertThrows(
com.google.api.gax.rpc.InvalidArgumentException.class,
() -> grpcClient.echo(errorRequest));

List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertThat(spans).hasSize(2);

SpanData grpcSuccessSpan = spans.get(0);
SpanData errorSpan = getErrorAttribute();
assertThat(
errorSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.ERROR_TYPE_ATTRIBUTE)))
.isEqualTo("UNAVAILABLE");
assertThat(
grpcSuccessSpan
errorSpan
.getAttributes()
.get(
AttributeKey.stringKey(
ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE)))
.isEqualTo("OK");

SpanData grpcErrorSpan = spans.get(1);
AttributeKey.stringKey(ObservabilityAttributes.EXCEPTION_TYPE_ATTRIBUTE)))
.isEqualTo("com.google.api.gax.rpc.UnavailableException");
assertThat(
grpcErrorSpan
errorSpan
.getAttributes()
.get(
AttributeKey.stringKey(
ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE)))
.isEqualTo("INVALID_ARGUMENT");
}
}

AttributeKey.stringKey(ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE)))
.isEqualTo("io.grpc.StatusRuntimeException: UNAVAILABLE");
}
}
@Test
void testTracing_failedEcho_httpjson_recordsErrorType() throws Exception {
void testTracing_failedEcho_httpjson_recordsErrorAttributes() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);

HttpTransport mockTransport =
Expand Down Expand Up @@ -625,9 +678,67 @@ public String getHeaderValue(int index) {
EchoRequest echoRequest = EchoRequest.newBuilder().build();

assertThrows(UnavailableException.class, () -> client.echo(echoRequest));
verifyErrorTypeAttribute("503");
SpanData errorSpan = getErrorAttribute();
assertThat(
errorSpan
.getAttributes()
.get(AttributeKey.stringKey(ObservabilityAttributes.ERROR_TYPE_ATTRIBUTE)))
.isEqualTo("503");
assertThat(
errorSpan
.getAttributes()
.get(
AttributeKey.stringKey(ObservabilityAttributes.EXCEPTION_TYPE_ATTRIBUTE)))
.isEqualTo("com.google.api.gax.rpc.UnavailableException");
assertThat(
errorSpan
.getAttributes()
.get(
AttributeKey.stringKey(ObservabilityAttributes.STATUS_MESSAGE_ATTRIBUTE)))
.isEqualTo("Service Unavailable");
}
}

@Test
void testTracing_statusCodes_grpc() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);
EchoRequest errorRequest = EchoRequest.newBuilder()
.setError(
Status.newBuilder().setCode(StatusCode.Code.INVALID_ARGUMENT.ordinal()).build())
.build();
EchoRequest successRequest = EchoRequest.newBuilder().setContent("tracing-test").build();

try (EchoClient grpcClient = TestClientInitializer.createGrpcEchoClientOpentelemetry(tracingFactory)) {

grpcClient.echo(successRequest);
assertThrows(
com.google.api.gax.rpc.InvalidArgumentException.class,
() -> grpcClient.echo(errorRequest));

List<SpanData> spans = spanExporter.getFinishedSpanItems();
assertThat(spans).hasSize(2);

SpanData grpcSuccessSpan = spans.get(0);
assertThat(
grpcSuccessSpan
.getAttributes()
.get(
AttributeKey.stringKey(
ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE)))
.isEqualTo("OK");

SpanData grpcErrorSpan = spans.get(1);
assertThat(
grpcErrorSpan
.getAttributes()
.get(
AttributeKey.stringKey(
ObservabilityAttributes.RPC_RESPONSE_STATUS_ATTRIBUTE)))
.isEqualTo("INVALID_ARGUMENT");
}
}

@Test
void testTracing_statusCodes_httpjson() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);
EchoRequest errorRequest =
Expand Down
Loading