chore: delete gax-httpjson reference in Release Please key#12683
chore: delete gax-httpjson reference in Release Please key#12683chingor13 merged 1 commit intogoogleapis:mainfrom
Conversation
The gax-httpjson artifact has used `gax` for the release please version key even before this migration:
```
<artifactId>gax-httpjson</artifactId>
<version>2.76.1-SNAPSHOT</version> <!-- {x-version-update:gax:current} -->
```
https://github.com/googleapis/sdk-platform-java/blob/febe86f1ea4f0b5e6d8454024ed499adb7dc9328/gax-java/gax-httpjson/pom.xml#L6
We don't need gax-httpjson in Release Please key.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the explicit version for the gax dependency in the google-cloud-storage-control pom.xml and updates the version update tags for gax-httpjson to reference gax. It also removes the gax-httpjson entry from versions.txt. I have no feedback to provide.
|
It got a mysterious compilation error:
Retrying. |
|
Retry worked. |
3 participants
The recent attempt to make a release pull request got a build failure due to gax-httpjson version number: #12674 (comment).
The gax-httpjson artifact has used
gaxfor the release please version key even before this migration:https://github.com/googleapis/sdk-platform-java/blob/febe86f1ea4f0b5e6d8454024ed499adb7dc9328/gax-java/gax-httpjson/pom.xml#L6
We don't need gax-httpjson in Release Please key.