Conversation
- Fix wrong subcommand: `generate` -> `add-new-library` (confirmed via GitHub workflow) - Replace Cloud Drop references with Buganizer ticket as the sole input source - Add conflict-checking step before script execution - Add special cases table for google/maps/* and google/shopping/* APIs - Add branch/PR creation step with owlbot:run label guidance - Expand generation_config_schema.md with all optional fields from the script - Update cloud_drop_mapping.md framing to remove Cloud Drop terminology
…ibrary-generation-skill
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill for generating Google Cloud Java client libraries, including comprehensive documentation on the workflow, configuration schema, and service YAML mapping. The review feedback identifies several inconsistencies across the documentation files regarding script names, directory paths, and CLI flag naming conventions. Additionally, the reviewer pointed out a typo in a Maven group ID and recommended replacing hardcoded user paths in example outputs with generic placeholders.
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| :warning: **IMPORTANT:** | ||
| Not all the `new-client.py` arguments are available in the Github Action. |
There was a problem hiding this comment.
The script name new-client.py is inconsistent with the actual script name add-new-client-config.py used elsewhere in the documentation.
| Not all the `new-client.py` arguments are available in the Github Action. | |
| Not all the add-new-client-config.py arguments are available in the Github Action. |
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
| (for local environment)" section). | ||
| For the explanation of the available parameters, run: | ||
| ``` | ||
| python3 generation/new_client_hermetic_build/add-new-client-config.py add-new-library --help |
There was a problem hiding this comment.
The subcommand add-new-library is inconsistent with the generate subcommand used in SKILL.md and service_yaml_mapping.md. Ensure the command assumes the user is in the repository root folder.
| python3 generation/new_client_hermetic_build/add-new-client-config.py add-new-library --help | |
| python3 generation/new_client_hermetic_build/add-new-client-config.py generate --help |
References
- Commands in documentation should assume the user is in the repository root folder, as this is a stated convention in the document.
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Trying out a new agent skill for new library generation requests. Uses internal MCP tools and skills to pull the relevant information.
Interestingly, this PR uses AI to generate commands to tell AI how to automatically generate a library request