chore: ensure we use the current version of the auth library in the monorepo#12690
Draft
chore: ensure we use the current version of the auth library in the monorepo#12690
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the google-auth-library version to 1.43.1-SNAPSHOT across multiple modules. However, it removes the centralized google.auth.version property from the parent POM and hardcodes the version string in individual files. The review feedback correctly identifies that the property should be maintained in the parent POM to ensure consistency and facilitate automated updates, recommending the use of the property reference instead of hardcoded values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dependency version of google-auth-library within the sdk-platform-java projects. This means that we must ensure that we also install google-auth-library whenever we need to install sdk-platform-java.