Skip to content

chore: sdk-platform-java partial release preparation#12703

Draft
suztomo wants to merge 2 commits intogoogleapis:mainfrom
suztomo:sdk-platform-java-partial-release
Draft

chore: sdk-platform-java partial release preparation#12703
suztomo wants to merge 2 commits intogoogleapis:mainfrom
suztomo:sdk-platform-java-partial-release

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Apr 7, 2026

The modules in sdk-platform-java should be non-SNAPSHOT.
Other modules are still in their SNAPSHOT versions but their build
should succeed.

b/500385320

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 7, 2026

Until the references to the sdk-platform-java modules exists, the build would fail. This still needs #12690.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares a release by updating version strings across numerous pom.xml files and the versions.txt file, moving from -SNAPSHOT to release versions. Feedback highlights significant version inconsistencies where several modules, including google-common-protos and various google-iam components, are being set to .0 versions instead of the expected .1 release versions. These discrepancies appear to stem from missed updates in the versions.txt file and should be corrected to ensure a consistent release state.

<artifactId>google-common-protos-parent</artifactId>
<packaging>pom</packaging>
<version>2.67.1-SNAPSHOT</version><!-- {x-version-update:proto-google-common-protos:current} -->
<version>2.67.0</version><!-- {x-version-update:proto-google-common-protos:current} -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version for google-common-protos-parent is being updated to 2.67.0, which is the current released version, effectively reverting it from 2.67.1-SNAPSHOT. In contrast, other modules in this PR (e.g., api-common, gax, google-cloud-core) are correctly moving from .1-SNAPSHOT to .1. This inconsistency suggests that versions.txt was not updated for proto-google-common-protos. If this module is intended to be part of the release, it should be set to 2.67.1.

Suggested change
<version>2.67.0</version><!-- {x-version-update:proto-google-common-protos:current} -->
<version>2.67.1</version><!-- {x-version-update:proto-google-common-protos:current} -->

<artifactId>google-iam-parent</artifactId>
<packaging>pom</packaging>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:proto-google-iam-v1:current} -->
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v1:current} -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version for google-iam-parent is being set to 1.62.0, which is inconsistent with the rest of the release preparation. Notably, google-iam-policy is correctly updated to 1.62.1 in versions.txt (line 590), and other core modules are moving to .1. Reverting the parent to 1.62.0 while related modules move to 1.62.1 will cause version mismatches. This should likely be 1.62.1.

Suggested change
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v1:current} -->
<version>1.62.1</version><!-- {x-version-update:proto-google-iam-v1:current} -->

Comment on lines +95 to +152
<version>2.67.0</version><!-- {x-version-update:proto-google-common-protos:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-common-protos</artifactId>
<version>2.67.1-SNAPSHOT</version><!-- {x-version-update:proto-google-common-protos:current} -->
<version>2.67.0</version><!-- {x-version-update:proto-google-common-protos:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v1</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:proto-google-iam-v1:current} -->
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v2</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:proto-google-iam-v2:current} -->
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v2:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v2beta</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:proto-google-iam-v2beta:current} -->
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v2beta:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v3</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:proto-google-iam-v3:current} -->
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v3:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-iam-v3beta</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:proto-google-iam-v3beta:current} -->
<version>1.62.0</version><!-- {x-version-update:proto-google-iam-v3beta:current} -->
</dependency>

<!-- Following test deps are kept to keep them consistent with versions above -->
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v1</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-iam-v1:current} -->
<version>1.62.0</version><!-- {x-version-update:grpc-google-iam-v1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v2</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-iam-v2:current} -->
<version>1.62.0</version><!-- {x-version-update:grpc-google-iam-v2:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v2beta</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-iam-v2beta:current} -->
<version>1.62.0</version><!-- {x-version-update:grpc-google-iam-v2beta:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v3</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-iam-v3:current} -->
<version>1.62.0</version><!-- {x-version-update:grpc-google-iam-v3:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-iam-v3beta</artifactId>
<version>1.62.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-iam-v3beta:current} -->
<version>1.62.0</version><!-- {x-version-update:grpc-google-iam-v3beta:current} -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Multiple dependencies in this BOM (including common-protos and various iam modules) are being set to versions ending in .0 (e.g., 2.67.0, 1.62.0), while other modules in the same PR are moving to .1. This is particularly problematic for the IAM modules since google-iam-policy is being released as 1.62.1. These should likely all be updated to their .1 counterparts to ensure a consistent release state.

gapic-generator-java:2.68.1:2.68.1
api-common:2.59.1:2.59.1
gax:2.76.1:2.76.1
gax-grpc:2.76.1:2.76.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While gax-grpc and other modules are correctly updated to .1 for release, several subsequent entries in this file (e.g., proto-google-common-protos at line 984 and proto-google-iam-v1 at line 986) appear to have been missed. This is causing the POM files to be updated to the old .0 versions instead of the intended .1 release versions. Please ensure all modules targeted for this partial release are updated in this file.

The modules in sdk-platform-java should be non-SNAPSHOT.
Other modules are still in their SNAPSHOT versions but their build
should succeed.

b/500385320
@suztomo suztomo force-pushed the sdk-platform-java-partial-release branch from c0e8bd9 to 5681623 Compare April 7, 2026 23:49
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 7, 2026

Error: 4:389 [ERROR] Failed to execute goal on project google-auth-library-appengine: Could not resolve dependencies for project com.google.auth:google-auth-library-appengine:jar:1.43.1-SNAPSHOT
Error: 4:389 [ERROR] dependency: com.google.api:api-common:jar:2.59.1 (compile)
Error: 4:389 [ERROR] 	Could not find artifact com.google.api:api-common:jar:2.59.1 in google-maven-central-copy (https://maven-central.storage-download.googleapis.com/maven2)
Error: 4:389 [ERROR] 	Could not find artifact com.google.api:api-common:jar:2.59.1 in maven-central (https://repo1.maven.org/maven2)
Error: 4:389 [ERROR] 	com.google.api:api-common:jar:2.59.1 was not found in https://maven-central.storage-download.googleapis.com/maven2/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of google-maven-central has elapsed or updates are forced
Error: 4:389 [ERROR] -> [Help 1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant