Skip to content

fix: update Version.java and correct spanner version for 1.83.0 release#12712

Merged
suztomo merged 6 commits intogoogleapis:mainfrom
suztomo:fix-1.83.0
Apr 8, 2026
Merged

fix: update Version.java and correct spanner version for 1.83.0 release#12712
suztomo merged 6 commits intogoogleapis:mainfrom
suztomo:fix-1.83.0

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Apr 8, 2026

Version.java was not updated by the apply_versions.sh #12713.

The spanner artifacts were not having correct version. This pull request fixes them. This source tree passed the check in https://github.com/googleapis/google-cloud-java/pull/12714/changes#diff-4dd8a804177e94b35097216011c8ccae349a9792ec7b0c8ba62209a69814f48b.

The empty line in google-cloud-pom-parent/pom.xml is for the release script to consider this commit is the full repository release.

This skips google-auth-library-java module and other modules are using the version already available in Maven Central. This is to remove the circular dependency of POM references.

Version.java was not updated.

The spanner artifacts are not having correct version.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version numbers for various Google Cloud Java client libraries and the Spanner BOM to their latest releases. I have no feedback to provide as these changes appear to be standard version bumps.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 8, 2026

Run docker run \
docker: Error response from daemon: manifest for gcr.io/cloud-devrel-public-resources/java-library-generation:2.69.0 not found: manifest unknown: Failed to fetch "2.69.0"

I have to use an old image version in .github/workflows/generated_files_sync.yaml

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 8, 2026

dependency compatibility test failed: https://github.com/googleapis/google-cloud-java/actions/runs/24143309252/job/70450633296?pr=12712

Error:  Failures: 
Error:    Slf4jUtilsTest.testGetLogger_loggingDisabled_shouldGetNOPLogger:61 expected: <org.slf4j.helpers.NOPLogger> but was: <com.google.api.gax.logging.TestLogger>

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 8, 2026

The compilation error is unexpected: https://github.com/googleapis/google-cloud-java/actions/runs/24143309494/job/70450439376?pr=12712

Error: 4:798 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project gax: Compilation failure: Compilation failure: 
Error: 4:798 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/PagingTest.java:[221,45] com.google.api.gax.rpc.testing.FakePagedApi.ListIntegersSizedPage has private access in com.google.api.gax.rpc.testing.FakePagedApi
Error: 4:798 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/PagingTest.java:[238,45] com.google.api.gax.rpc.testing.FakePagedApi.ListIntegersSizedPage has private access in com.google.api.gax.rpc.testing.FakePagedApi

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Apr 8, 2026

This seems persistent.

sdk-platform-java Java 17
https://github.com/googleapis/google-cloud-java/actions/runs/24146626749/job/70463247773?pr=12712

Error: 0:811 [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.101 s <<< FAILURE! -- in com.google.api.gax.logging.Slf4jUtilsTest
Error: 0:811 [ERROR] com.google.api.gax.logging.Slf4jUtilsTest.testGetLogger_loggingDisabled_shouldGetNOPLogger -- Time elapsed: 0.007 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <org.slf4j.helpers.NOPLogger> but was: <com.google.api.gax.logging.TestLogger>

sdk-platform-java Java 8
https://github.com/googleapis/google-cloud-java/actions/runs/24146626749/job/70463247180?pr=12712

Error: 8:263 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:testCompile (default-testCompile) on project gax: Compilation failure: Compilation failure: 
Error: 8:264 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/PagingTest.java:[221,45] com.google.api.gax.rpc.testing.FakePagedApi.ListIntegersSizedPage has private access in com.google.api.gax.rpc.testing.FakePagedApi
Error: 8:264 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/PagingTest.java:[238,45] com.google.api.gax.rpc.testing.FakePagedApi.ListIntegersSizedPage has private access in com.google.api.gax.rpc.testing.FakePagedApi

@suztomo suztomo marked this pull request as ready for review April 8, 2026 19:30
@suztomo suztomo requested review from a team as code owners April 8, 2026 19:30
@suztomo suztomo merged commit c2147fc into googleapis:main Apr 8, 2026
119 of 125 checks passed
@suztomo suztomo deleted the fix-1.83.0 branch April 8, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants