fix: remove Version.java from extra-files in release-please-config#12717
Draft
diegomarquezp wants to merge 1 commit intomainfrom
Draft
fix: remove Version.java from extra-files in release-please-config#12717diegomarquezp wants to merge 1 commit intomainfrom
diegomarquezp wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the glob patterns for
Version.javafiles from theextra-filesconfiguration inrelease-please-config.json.Reasoning:
Previously,
Version.javafiles were configured asgenerictype inextra-files. TheGenericupdater does not support the{x-version-update-start:component:current}markers used in these files. By removing them fromextra-files, theJavaYoshiMonoRepostrategy will fallback to its native mechanism to find and updateVersion.javafiles usingJavaUpdate, which correctly handles these markers.See the
JavaYoshiMonoRepostrategy implementation here: java-yoshi-mono-repo.ts where it searches forVersion.java.Verified by adding a unit test in
release-pleaserepository (see googleapis/release-please#2737).