chore: untangling auth library parent and imported BOM#12737
chore: untangling auth library parent and imported BOM#12737suztomo wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's parent POM configuration to use google-cloud-shared-config instead of the previous parent, updates various dependency versions, and refines the dependencyManagement section. Feedback was provided regarding the hardcoded version of mockito-core, the potential build failure for mockito-junit-jupiter due to the parent change, and the ambiguity of the <!-- Do not import --> comment in the POM file.
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <version>4.11.0</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
The version for mockito-core is hardcoded here. It is recommended to use a property for consistency with other dependencies in this file. Additionally, the subsequent dependency mockito-junit-jupiter (starting at line 149) is missing a version; since the parent has changed from google-cloud-jar-parent to google-cloud-shared-config, it is likely no longer managed and will cause a build failure if a version is not explicitly provided.
google-auth-library-java/pom.xml
Outdated
| </properties> | ||
|
|
||
| <dependencyManagement> | ||
| <!-- Do not import --> |
There was a problem hiding this comment.
The comment <!-- Do not import --> is ambiguous and potentially misleading, as it is immediately followed by several dependencies with <scope>import</scope>. If the intention is to discourage importing this root POM as a BOM, it should be clarified or moved to a more appropriate location. If it is a leftover from a previous iteration, it should be removed.
| <project.findbugs.version>3.0.2</project.findbugs.version> | ||
| <deploy.autorelease>false</deploy.autorelease> | ||
| <project.error-prone.version>2.38.0</project.error-prone.version> | ||
| <project.error-prone.version>2.42.0</project.error-prone.version> |
There was a problem hiding this comment.
Anything that requires this update?
There was a problem hiding this comment.
Guava depends on this newer version and upper-bound check was failing.
2 participants
Maven Central does not allow uploading a set of artifacts having different group IDs.
com.google.cloud.