Skip to content

build(sdk-platform-java): Add formatter plugin to the root pom of sdk-platform-java. #12739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blakeli0 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

build(sdk-platform-java): Add formatter plugin to the root pom of sdk-platform-java. #12739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk-platform-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@
<!-- Do not deploy the aggregator POM -->
<build>
<plugins>
<plugin>
<groupId>com.spotify.fmt</groupId>
<artifactId>fmt-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
Comment on lines +32 to +38
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding the plugin with true in the root POM's section will be inherited by all submodules, effectively disabling the formatter for the entire project. Additionally, the plugin is missing a version, which is necessary for build reproducibility unless it is managed by a parent POM.

To resolve the errors at the root while allowing submodules to be formatted, you should:

  1. Specify a version (e.g., 2.9.1).
  2. Remove the true configuration. The plugin typically handles projects without Java source files (like this aggregator POM) gracefully. If you must skip it for the root only, use false.

Note: com.spotify.fmt is no longer maintained; com.hubspot.maven.plugins:fmt-maven-plugin is the recommended replacement for modern Java projects.

      <plugin>
        <groupId>com.spotify.fmt</groupId>
        <artifactId>fmt-maven-plugin</artifactId>
        <version>2.9.1</version>
      </plugin>
References
  1. Dependency versions in example code do not need to be kept strictly up-to-date with the latest version in the pull request.

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
Expand Down
Loading