chore(spanner): track latency when using KeyAwareChannel#12744
Open
chore(spanner): track latency when using KeyAwareChannel#12744
Conversation
Track latency for streaming SQL and streaming reads that return only one PartialResultSet. The choice for which RPCs are eligible for tracking is done by the LatencyTracker. This allows us to include/exclude more RPCs in the future.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces latency tracking for Spanner gRPC calls by integrating a LatencyTracker into the ChannelEndpoint and KeyAwareChannel. It specifically measures the time to the first response message for streaming read and SQL operations using an Exponential Weighted Moving Average (EWMA) tracker. Review feedback highlights several breaking changes to the LatencyTracker public API, recommending the use of default interface methods and maintaining the visibility of existing methods to ensure backward compatibility.
...anner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/LatencyTracker.java
Show resolved
Hide resolved
...anner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/LatencyTracker.java
Show resolved
Hide resolved
...r/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/EwmaLatencyTracker.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track latency for streaming SQL and streaming reads that return only one PartialResultSet. The choice for which RPCs are eligible for tracking is done by the LatencyTracker. This allows us to include/exclude more RPCs in the future.