Skip to content

test(spanner): add timeouts to AsyncResultSetImplTest #12751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olavloite wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −6
Open

test(spanner): add timeouts to AsyncResultSetImplTest #12751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions ...r/google-cloud-spanner/src/test/java/com/google/cloud/spanner/AsyncResultSetImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.google.cloud.spanner.AsyncResultSet.CursorState;
import com.google.cloud.spanner.AsyncResultSet.ReadyCallback;
import com.google.common.base.Function;
import com.google.common.base.Stopwatch;
import com.google.common.collect.Range;
import com.google.protobuf.ByteString;
import com.google.protobuf.Value;
Expand All @@ -50,7 +51,9 @@
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.Timeout;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
import org.mockito.Mockito;
Expand All @@ -59,6 +62,8 @@

@RunWith(JUnit4.class)
public class AsyncResultSetImplTest {
@Rule public final Timeout globalTimeout = Timeout.seconds(60);

private ExecutorProvider mockedProvider;
private ExecutorProvider simpleProvider;

Expand Down Expand Up @@ -198,7 +203,7 @@ public void withCallback() throws InterruptedException {
return CallbackResponse.CONTINUE;
});
}
finishedLatch.await();
assertThat(finishedLatch.await(10, TimeUnit.SECONDS)).isTrue();
// There should be between 1 and 5 callbacks, depending on the timing of the threads.
// Normally, there should be just 1 callback.
assertThat(callbackCounter.get()).isIn(Range.closed(1, 5));
Expand Down Expand Up @@ -228,7 +233,8 @@ public void callbackReceivesError() throws InterruptedException {
return CallbackResponse.DONE;
});
}
Exception e = receivedErr.take();
Exception e = receivedErr.poll(10, TimeUnit.SECONDS);
assertThat(e).isNotNull();
assertThat(e).isInstanceOf(SpannerException.class);
SpannerException se = (SpannerException) e;
assertThat(se.getErrorCode()).isEqualTo(ErrorCode.INVALID_ARGUMENT);
Expand Down Expand Up @@ -263,7 +269,8 @@ public void callbackReceivesErrorHalfwayThrough() throws InterruptedException {
return CallbackResponse.DONE;
});
}
Exception e = receivedErr.take();
Exception e = receivedErr.poll(10, TimeUnit.SECONDS);
assertThat(e).isNotNull();
assertThat(e).isInstanceOf(SpannerException.class);
SpannerException se = (SpannerException) e;
assertThat(se.getErrorCode()).isEqualTo(ErrorCode.INVALID_ARGUMENT);
Expand Down Expand Up @@ -300,8 +307,12 @@ public void pauseResume() throws InterruptedException {
return CallbackResponse.DONE;
});
int rowCounter = 0;
Stopwatch stopwatch = Stopwatch.createStarted();
while (!finished.get()) {
Object o = queue.poll(1L, TimeUnit.MILLISECONDS);
if (stopwatch.elapsed(TimeUnit.SECONDS) > 10) {
throw new RuntimeException("Test timed out waiting for finished");
}
Object o = queue.poll(10L, TimeUnit.MILLISECONDS);
if (o != null) {
rowCounter++;
}
Expand Down Expand Up @@ -359,8 +370,12 @@ public Boolean answer(InvocationOnMock invocation) throws Throwable {
}
});
int rowCounter = 0;
Stopwatch stopwatch = Stopwatch.createStarted();
while (!callbackResult.isDone()) {
Object o = queue.poll(1L, TimeUnit.MILLISECONDS);
if (stopwatch.elapsed(TimeUnit.SECONDS) > 10) {
throw new RuntimeException("Test timed out waiting for callbackResult");
}
Object o = queue.poll(10L, TimeUnit.MILLISECONDS);
if (o != null) {
rowCounter++;
}
Expand Down Expand Up @@ -453,8 +468,12 @@ public void cancel() throws InterruptedException {
return CallbackResponse.DONE;
});
int rowCounter = 0;
Stopwatch stopwatch = Stopwatch.createStarted();
while (!finished.get()) {
Object o = queue.poll(1L, TimeUnit.MILLISECONDS);
if (stopwatch.elapsed(TimeUnit.SECONDS) > 10) {
throw new RuntimeException("Test timed out waiting for finished");
}
Object o = queue.poll(10L, TimeUnit.MILLISECONDS);
if (o != null) {
rowCounter++;
}
Expand Down
Loading