Skip to content

ci: fix dependency-compatibility check #12837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 1 commit into from
Apr 17, 2026
+5 −11
Merged

ci: fix dependency-compatibility check #12837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/logging/Slf4jUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import com.google.protobuf.Option;
import java.util.HashMap;
import java.util.Map;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
import org.slf4j.Logger;
Expand All @@ -56,6 +57,7 @@ class Slf4jUtilsTest {

// This test should only run GOOGLE_SDK_JAVA_LOGGING != true
@Test
@Disabled("See https://github.com/googleapis/google-cloud-java/issues/12836")
Comment thread
chingor13 marked this conversation as resolved.
void testGetLogger_loggingDisabled_shouldGetNOPLogger() {
Logger logger = Slf4jUtils.getLogger(Slf4jUtilsTest.class);
assertEquals(NOPLogger.class, logger.getClass());
Expand Down
14 changes: 3 additions & 11 deletions settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,7 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
https://maven.apache.org/xsd/settings-1.0.0.xsd">
<mirrors>
<mirror>
<!-- Google's Maven Central mirror for Americas
https://maven-central.storage.googleapis.com/index.html
-->
<id>google-maven-central</id>
<name>GCS Maven Central mirror</name>
<url>https://maven-central.storage-download.googleapis.com/maven2/</url>
<mirrorOf>central</mirrorOf>
</mirror>
</mirrors>
<!-- This file contains settings used by .kokoro/build.sh. These are global
Comment thread
chingor13 marked this conversation as resolved.
configs used by almost every build script.
-->
</settings>
Loading