chore(managed-identities): rm unused config API path#12856
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
hmm, we got no changed libraries |
|
|
Forced a code generation for this library by a temp change (3e4f22a) reverted above temp change. |
|
This reverts commit 3e4f22a.
|
@blakeli0 PTAL. |
Please correct me if I'm misunderstanding this, but does this mean that the reason we don't have v1beta1 library is because of a config error on our end? If so, do we want to fix this so that managedidentities v1beta1 is generated properly? |
|
NVM, I see in the librarian ticket:
Ok, I think removing the samples if fine for now. Do we have a ticket to generate it after migration (if we still want to)? |
Since this is v1beta1 and we never generated before, I think it's OK to not generate it for now. We can always add it back if someone needs it. |
|
updated branch in attempt to trigger the required "conditional-required-check" test |
Removing unused API path from config for managed-identities, so that it matches the generated code status. v1beta1 of java-managed-identities was added to the generation_config.yaml as part of initial migration to hermetic build: googleapis@14b7346, but client library code for v1beta1 is not present in java-managed-identities/google-cloud-managed-identities dir. This is due to deep-copy-regex being too strict and does not copy /v1beta1 from staging dir to final output. Expect generation workflow to remove sample code related to v1beta1. For googleapis#12736 For googleapis/librarian#5370 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
4 participants
Removing unused API path from config for managed-identities, so that it matches the generated code status.
v1beta1 of java-managed-identities was added to the generation_config.yaml as part of initial migration to hermetic build: 14b7346, but client library code for v1beta1 is not present in java-managed-identities/google-cloud-managed-identities dir. This is due to deep-copy-regex being too strict and does not copy /v1beta1 from staging dir to final output.
Expect generation workflow to remove sample code related to v1beta1.
For #12736
For googleapis/librarian#5370