feat(bqjdbc): Per connection logs - Add PerConnectionFileHandler#12899
Merged
feat(bqjdbc): Per connection logs - Add PerConnectionFileHandler#12899
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements connection-specific logging via a new PerConnectionFileHandler and restricts the visibility of BigQueryJdbcMdc members. The review feedback focuses on preventing resource leaks by managing the lifecycle of internal FileHandler instances and improving robustness through null checks, exception-safe resource closure, and the use of ErrorManager for internal error reporting.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
logachev
approved these changes
Apr 23, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Apr 24, 2026
…gleapis#12899) - PerConnectionFileHandler.java: Introduced a logging handler mapping logs via InheritableThreadLocal constructs. - BigQueryJdbcMdc.java: Reduced interface exposure to strict package scopes. - PerConnectionFileHandlerTest.java: Introduced coverage validations verifying default execution routing. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.