[testing] ci: fix unmanaged dependency check#12924
Conversation
chingor13
force-pushed
the
fix-unmanaged-dep-check
branch
from
b14b15f to
448167b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates project versions to snapshots and synchronizes x-version-update tags across the repository. Feedback identifies inconsistencies in the version update tags within the Access Context Manager and Analytics Admin modules, where tags used for parent versions or dependencies do not match the definitions in the corresponding BOMs or other modules in the same library. These discrepancies should be resolved to ensure reliable automation for future updates.
| <artifactId>google-identity-accesscontextmanager-parent</artifactId> | ||
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| <version>1.93.0-SNAPSHOT</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| </parent> |
There was a problem hiding this comment.
The version update tag for the parent version is inconsistent with other modules in this library. It should use the main library tag google-identity-accesscontextmanager instead of the specific v1 proto tag.
<version>1.93.0-SNAPSHOT</version><!-- {x-version-update:google-identity-accesscontextmanager:current} -->
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-identity-accesscontextmanager-type</artifactId> | ||
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| <version>1.93.0-SNAPSHOT</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> |
There was a problem hiding this comment.
The version update tag for the proto-google-identity-accesscontextmanager-type dependency should be aligned with the tag used in the artifact's own POM and the BOM to ensure consistent updates.
| <version>1.93.0-SNAPSHOT</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | |
| <version>1.93.0-SNAPSHOT</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-type:current} --> |
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-analytics-admin-v1alpha</artifactId> | ||
| <version>0.101.0</version><!-- {x-version-update:proto-google-analytics-admin-v1alpha:current} --> | ||
| <version>0.102.0-SNAPSHOT</version><!-- {x-version-update:proto-google-analytics-admin-v1alpha:current} --> |
There was a problem hiding this comment.
The version update tag for this artifact (google-analytics-admin) is inconsistent with its definition in the BOM (proto-google-analytics-admin-v1alpha). This systematic inconsistency should be corrected to ensure all occurrences of the version are updated correctly by automation tools.
|
|
chingor13
added
the
do not merge
chingor13
changed the title
1 participant
No description provided.