Skip to content

build: stop managing java-showcase Version.java#12926

Merged
blakeli0 merged 1 commit intomainfrom
skip-showcase-version-bump
Apr 24, 2026
Merged

build: stop managing java-showcase Version.java#12926
blakeli0 merged 1 commit intomainfrom
skip-showcase-version-bump

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 24, 2026

Fixes #12914

This will prevent release-please from bumping the version in Versions.java in java-showcase because it won't have a version to replace with.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the gapic-showcase, proto-gapic-showcase-v1beta1, and grpc-gapic-showcase-v1beta1 dependencies from the versions.txt file. I have no feedback to provide.

@chingor13 chingor13 marked this pull request as ready for review April 24, 2026 18:40
@chingor13 chingor13 requested a review from a team as a code owner April 24, 2026 18:40
@blakeli0 blakeli0 merged commit d59af0c into main Apr 24, 2026
120 checks passed
@blakeli0 blakeli0 deleted the skip-showcase-version-bump branch April 24, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Showcase tests failed in the release PR

2 participants