test: fix testOpenTelemetryTracingDatasets by setting explicit location#12932
Open
test: fix testOpenTelemetryTracingDatasets by setting explicit location#12932
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the testOpenTelemetryTracingDatasets integration test in ITBigQueryTest.java to explicitly set a dataset location of 'US' and verifies that this location is correctly captured in the OpenTelemetry tracing attributes. I have no feedback to provide as there were no review comments and the changes are straightforward test updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the testOpenTelemetryTracingDatasets failure by explicitly setting the dataset location to US, making it deterministic across environments.
This test has been flaky because the environment would assign a location if it is not set explicitly. See test failures log for details.