Skip to content

test: fix testOpenTelemetryTracingDatasets by setting explicit location #12932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blakeli0 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: fix testOpenTelemetryTracingDatasets by setting explicit location #12932

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab46730
test: fix testOpenTelemetryTracingDatasets by setting explicit location
blakeli0 Apr 24, 2026
b9e91d6
test: set location in BigQueryOptions to US in ITBigQueryTest
blakeli0 Apr 24, 2026
9f785b4
test: remove redundant setLocation on DatasetInfo in ITBigQueryTest
blakeli0 Apr 24, 2026
d1ff489
test: set location in both options and dataset info to fix flakiness
blakeli0 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...uery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7801,6 +7801,7 @@ public void testOpenTelemetryTracingDatasets() {
BigQueryOptions.newBuilder()
.setEnableOpenTelemetryTracing(true)
.setOpenTelemetryTracer(tracer)
.setLocation("US")
.build();
BigQuery bigquery = otelOptions.getService();

Expand All @@ -7818,6 +7819,7 @@ public void testOpenTelemetryTracingDatasets() {
.setDescription(DESCRIPTION)
.setMaxTimeTravelHours(72L)
.setLabels(LABELS)
.setLocation("US")
.build();

Dataset dataset = bigquery.create(info);
Expand All @@ -7839,7 +7841,7 @@ public void testOpenTelemetryTracingDatasets() {
parentSpan.end();
Map<AttributeKey<?>, Object> createMap =
OTEL_ATTRIBUTES.get("com.google.cloud.bigquery.BigQuery.createDataset");
assertEquals("null", createMap.get(AttributeKey.stringKey("bq.dataset.location")));
assertEquals("US", createMap.get(AttributeKey.stringKey("bq.dataset.location")));
assertEquals(
"DatasetService",
OTEL_ATTRIBUTES
Expand Down
Loading