Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a suite of tools for the BigQuery JDBC driver, including a Java-based client, performance benchmarking scripts, and Terraform configurations for Private Service Connect environments. Key feedback includes implementing try-with-resources for better resource management in the Java client, using System.nanoTime() for more accurate performance metrics, removing hardcoded usernames from Terraform outputs, and improving the portability of the Python performance script.
Neenu1995
approved these changes
May 1, 2026
lqiu96
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environments:
Tools:
More details are in README docs for each tool