Skip to content

fix(bigquery-jdbc): handle EXPORT DATA, EXPORT MODEL, and LOAD DATA statements #13267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keshavdandeva merged 4 commits into from
May 27, 2026
Merged

fix(bigquery-jdbc): handle EXPORT DATA, EXPORT MODEL, and LOAD DATA statements #13267

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c091d9d
fix: handle EXPORT DATA, EXPORT MODEL, and LOAD DATA statements
keshavdandeva May 26, 2026
2f0c7c6
chore: address pr feedback
keshavdandeva May 26, 2026
25f61e6
chore: remove throwing exception from OTHER
keshavdandeva May 26, 2026
c32819d
chore: address pr feedback
keshavdandeva May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQuerySqlTypeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ static SqlType getSqlTypeFromStatementType(StatementType statementType) {
case "ROLLBACK_TRANSACTION":
return SqlType.TCL;
case "EXPORT_DATA":
return SqlType.EXPORT;
case "EXPORT_MODEL":
case "LOAD_DATA":
Comment thread
keshavdandeva marked this conversation as resolved.
default:
Expand Down
50 changes: 40 additions & 10 deletions java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,15 +685,9 @@ void handleQueryResult(String query, TableResult results, SqlType queryType)
break;
case DML:
case DML_EXTRA:
try {
Job completedJob = this.bigQuery.getJob(results.getJobId()).waitFor();
JobStatistics.QueryStatistics statistics = completedJob.getStatistics();
updateAffectedRowCount(statistics.getNumDmlAffectedRows());
} catch (InterruptedException ex) {
throw new BigQueryJdbcRuntimeException(ex);
} catch (NullPointerException ex) {
throw new BigQueryJdbcException(ex);
}
QueryStatistics dmlStats = getQueryStatisticsFromJob(results);
Long dmlRowCount = (dmlStats != null) ? dmlStats.getNumDmlAffectedRows() : null;
Comment thread
keshavdandeva marked this conversation as resolved.
Outdated
updateAffectedRowCount(dmlRowCount);
break;
case TCL:
case DDL:
Expand Down Expand Up @@ -725,8 +719,43 @@ void handleQueryResult(String query, TableResult results, SqlType queryType)
throw new BigQueryJdbcException(ex);
}
break;
case EXPORT:
QueryStatistics exportStats = getQueryStatisticsFromJob(results);
Long exportRowCount = 0L;
if (exportStats != null) {
QueryStatistics.ExportDataStats dataStats = exportStats.getExportDataStats();
if (dataStats != null && dataStats.getRowCount() != null) {
exportRowCount = dataStats.getRowCount();
}
}
updateAffectedRowCount(exportRowCount);
break;
case OTHER:
throw new BigQueryJdbcException(String.format("Unexpected value: " + queryType));
String truncatedQuery =
Comment thread
keshavdandeva marked this conversation as resolved.
Outdated
(query != null && query.length() > 60) ? query.substring(0, 60) + "..." : query;
String jobId = (results.getJobId() != null) ? results.getJobId().getJob() : "unknown";
Comment thread
logachev marked this conversation as resolved.
Outdated
LOG.warning(
"Encountered unmapped SQL statement type [Job ID: %s]. Treating as update statement: %s",
jobId, truncatedQuery);
Comment thread
keshavdandeva marked this conversation as resolved.
Outdated
updateAffectedRowCount(results.getTotalRows());
break;
}
}

private QueryStatistics getQueryStatisticsFromJob(TableResult results) throws SQLException {
try {
Job job = this.bigQuery.getJob(results.getJobId());
Job completedJob = (job != null) ? job.waitFor() : null;
JobStatistics stats = (completedJob != null) ? completedJob.getStatistics() : null;
if (stats instanceof QueryStatistics) {
return (QueryStatistics) stats;
}
return null;
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
throw new BigQueryJdbcRuntimeException("Interrupted while waiting for job completion", ex);
} catch (BigQueryException ex) {
throw new BigQueryJdbcException("BigQueryException while waiting for job completion", ex);
}
}

Expand Down Expand Up @@ -1610,6 +1639,7 @@ enum SqlType {
DDL,
SCRIPT,
TCL,
EXPORT,
OTHER
}

Expand Down
Loading