Skip to content

test(bigquery): fix flaky testInsertAll by adding insert IDs#13414

Merged
jinseopkim0 merged 1 commit into
mainfrom
fix-flaky-insert-all-b495487323
Jun 10, 2026
Merged

test(bigquery): fix flaky testInsertAll by adding insert IDs#13414
jinseopkim0 merged 1 commit into
mainfrom
fix-flaky-insert-all-b495487323

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

b/495487323

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration tests in ITBigQueryTest.java to use randomly generated UUIDs as row IDs when adding rows to InsertAllRequest. This change is applied to testInsertAll, testInsertAllWithSuffix, and testInsertAllWithErrors. There are no review comments, and I have no feedback to provide.

@jinseopkim0 jinseopkim0 marked this pull request as ready for review June 10, 2026 17:56
@jinseopkim0 jinseopkim0 requested review from a team as code owners June 10, 2026 17:56
@jinseopkim0 jinseopkim0 enabled auto-merge (squash) June 10, 2026 17:56
@jinseopkim0 jinseopkim0 requested a review from lqiu96 June 10, 2026 17:56

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. maybe the title should be test(bigquery) so avoid the release notes for a flaky test?

@jinseopkim0 jinseopkim0 merged commit 4236143 into main Jun 10, 2026
182 checks passed
@jinseopkim0 jinseopkim0 deleted the fix-flaky-insert-all-b495487323 branch June 10, 2026 19:12
@jinseopkim0 jinseopkim0 changed the title fix(bigquery): fix flaky testInsertAll by adding insert IDs test(bigquery): fix flaky testInsertAll by adding insert IDs Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants