test(auth): resolve flakiness in ClientSideCredentialAccessBoundaryFactoryTest#13433
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a race condition in ClientSideCredentialAccessBoundaryFactory by synchronizing the token refresh decision and task creation, and re-enables a previously disabled multi-threaded test. The reviewer suggests optimizing performance by using a double-checked locking pattern with an explicit lock (such as ReentrantLock) instead of the synchronized block on the hot path to avoid unnecessary lock contention when no refresh is needed.
lqiu96
force-pushed
the
fix/cab-token-flakiness
branch
2 times, most recently
from
fe5fb32 to
4cdb67c
Compare
…toryTest Synchronize the decision to refresh and task creation to avoid race conditions. Use Double-Checked Locking to minimize lock contention on the hot path. Resolves: googleapis#12871
lqiu96
force-pushed
the
fix/cab-token-flakiness
branch
from
4cdb67c to
83b1a5b
Compare
jinseopkim0
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12871
Synchronize the decision to refresh and task creation to avoid race conditions.