Skip to content

chore: add comment markers to pom.xml files#13443

Merged
zhumin8 merged 2 commits into
googleapis:mainfrom
zhumin8:insert-markers
Jun 11, 2026
Merged

chore: add comment markers to pom.xml files#13443
zhumin8 merged 2 commits into
googleapis:mainfrom
zhumin8:insert-markers

Conversation

@zhumin8

@zhumin8 zhumin8 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Add comment markers in pom.xml for generated proto and grpc artifacts.
These markers are added in parent, BOM and client pom.xml files for each library.

Removing some markers to showcase, because hermetic build code gen is used in showcase golden tests. Will work on it separately googleapis/librarian#6393.

For googleapis/librarian#6134

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces structural marker comments (such as <!-- {x-generated-dependencies-start} -->, <!-- {x-generated-proto-dependencies-start} -->, and <!-- {x-generated-modules-start} -->) across the pom.xml files of various Google Cloud Java client libraries. These tags are used to delineate generated dependency and module blocks, facilitating automated updates and code generation. There are no review comments on this pull request, and I have no feedback to provide.

@zhumin8 zhumin8 marked this pull request as ready for review June 11, 2026 19:32
@zhumin8 zhumin8 requested review from a team as code owners June 11, 2026 19:32
@zhumin8 zhumin8 requested review from JoeWang1127 and sofisl June 11, 2026 19:32
@zhumin8 zhumin8 merged commit 291add8 into googleapis:main Jun 11, 2026
316 of 320 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants