Skip to content

test(auth): verify GoogleCredentials.fromStream throws IOException on invalid JSON #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
westarle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(auth): verify GoogleCredentials.fromStream throws IOException on invalid JSON #13473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
328c2ef
test(auth): verify GoogleCredentials.fromStream throws IOException on…
westarle Jun 15, 2026
c15bca4
Merge branch 'main' into fix-test-gap-java-invalid-json
westarle Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/GoogleCredentialsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
Expand Down Expand Up @@ -122,9 +123,20 @@ void fromStream_unknownType_throws() throws IOException {
}
}

@Test
void fromStream_invalidJson_throws() throws IOException {
// This test ensures Java successfully throws an IOException when ADC JSON parsing
// fails, preventing silent fallbacks.
MockHttpTransportFactory transportFactory = new MockHttpTransportFactory();
try (InputStream stream =
new ByteArrayInputStream("invalid-json{".getBytes(StandardCharsets.UTF_8))) {
assertThrows(IOException.class, () -> GoogleCredentials.fromStream(stream, transportFactory));
}
}

@Test
void fromStream_nullTransport_throws() {
InputStream stream = new ByteArrayInputStream("foo".getBytes());
InputStream stream = new ByteArrayInputStream("foo".getBytes(StandardCharsets.UTF_8));
assertThrows(NullPointerException.class, () -> GoogleCredentials.fromStream(stream, null));
}

Expand Down
Loading