Skip to content

feat(bigquery-jdbc): migrate statement execution thread tracking to connection-scoped executor#13479

Closed
Neenu1995 wants to merge 7 commits into
mainfrom
pr-1-executor-migration
Closed

feat(bigquery-jdbc): migrate statement execution thread tracking to connection-scoped executor#13479
Neenu1995 wants to merge 7 commits into
mainfrom
pr-1-executor-migration

Conversation

@Neenu1995

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors background task management across several result set and statement classes to use Future instead of raw Thread references, mitigating potential out-of-memory errors by introducing a bounded cached thread pool. A temporary compatibility bridge wrapThread is added to BigQueryDatabaseMetaData to wrap raw threads into Futures. Feedback on the changes points out a missing import for CancellationException in BigQueryDatabaseMetaData.java which would cause a compilation error.

Comment on lines 72 to +75
import java.util.concurrent.Future;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The class CancellationException is used in the wrapThread method but is not imported in this file. This will cause a compilation error. Please add the import for java.util.concurrent.CancellationException.

Suggested change
import java.util.concurrent.Future;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.CancellationException;
import java.util.concurrent.Future;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

@Neenu1995 Neenu1995 closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant