feat(bigquery-jdbc): configure protobuf plugin and add clientanalytics.proto#13527
Open
Neenu1995 wants to merge 1 commit into
Open
feat(bigquery-jdbc): configure protobuf plugin and add clientanalytics.proto#13527Neenu1995 wants to merge 1 commit into
Neenu1995 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures Maven to support Protocol Buffers by adding the os-maven-plugin extension and the protobuf-maven-plugin plugin, and introduces a new clientanalytics.proto file defining telemetry-related messages. The feedback suggests renaming the repeated field log_event to log_events to follow the Google Protocol Buffers Style Guide, and reordering the fields sequentially by tag number for better readability.
Neenu1995
force-pushed
the
jdbc-telemetry-pr1
branch
from
f914f74 to
c9e6dca
Compare
Neenu1995
force-pushed
the
jdbc-telemetry-pr1
branch
from
c9e6dca to
89a20da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.